Merge pull request #923 from tdd/master
Fixed #687 casper.test fail event no longer fired using the --fail-fast option
Showing
3 changed files
with
13 additions
and
2 deletions
... | @@ -129,7 +129,7 @@ EventEmitter.prototype.addListener = function addListener(type, listener) { | ... | @@ -129,7 +129,7 @@ EventEmitter.prototype.addListener = function addListener(type, listener) { |
129 | } else if (isArray(this._events[type])) { | 129 | } else if (isArray(this._events[type])) { |
130 | 130 | ||
131 | // If we've already got an array, just append. | 131 | // If we've already got an array, just append. |
132 | this._events[type].push(listener); | 132 | this._events[type]['fail' === type ? 'unshift' : 'push'](listener); |
133 | 133 | ||
134 | // Check for listener leak | 134 | // Check for listener leak |
135 | if (!this._events[type].warned) { | 135 | if (!this._events[type].warned) { |
... | @@ -151,7 +151,7 @@ EventEmitter.prototype.addListener = function addListener(type, listener) { | ... | @@ -151,7 +151,7 @@ EventEmitter.prototype.addListener = function addListener(type, listener) { |
151 | } | 151 | } |
152 | } else { | 152 | } else { |
153 | // Adding the second element, need to change to array. | 153 | // Adding the second element, need to change to array. |
154 | this._events[type] = [this._events[type], listener]; | 154 | this._events[type] = 'fail' === type ? [listener, this._events[type]] : [this._events[type], listener]; |
155 | } | 155 | } |
156 | 156 | ||
157 | return this; | 157 | return this; | ... | ... |
tests/clitests/fail-fast/standard/hook.js
0 → 100644
... | @@ -391,6 +391,7 @@ class TestCommandOutputTest(CasperExecTestBase): | ... | @@ -391,6 +391,7 @@ class TestCommandOutputTest(CasperExecTestBase): |
391 | self.assertCommandOutputContains('test %s --fail-fast' % folder_path, [ | 391 | self.assertCommandOutputContains('test %s --fail-fast' % folder_path, [ |
392 | '# test 1', | 392 | '# test 1', |
393 | '# test 2', | 393 | '# test 2', |
394 | 'fail event fired!', | ||
394 | '--fail-fast: aborted all remaining tests', | 395 | '--fail-fast: aborted all remaining tests', |
395 | 'FAIL 2 tests executed', | 396 | 'FAIL 2 tests executed', |
396 | '1 passed', | 397 | '1 passed', | ... | ... |
-
Please register or sign in to post a comment