Skip to content

John McEleney / casperjs

Go to a project
Toggle navigation
Toggle navigation pinning
Commit c87131c1 c87131c1c9a52448a5f1ce3361a7bc5dbeffd280 by Nicolas Perriault
Options

Merge pull request #855 from tohann/master 

Add style.display check for inline-block when determining element visibility
2 parents 38435be8 b754bf80
Inline Side-by-side
Showing 2 changed files with 21 additions and 1 deletions
......@@ -164,7 +164,7 @@
if (hidden) {
return false;
}
if (style.display === "inline") {
if (style.display === "inline" || style.display === "inline-block") {
return true;
}
return elem.clientHeight > 0 && elem.clientWidth > 0;
......
......@@ -201,3 +201,23 @@ casper.test.begin('ClientUtils.getElementsInfo() second element tests', 10, func
'ClientUtils.getElementsInfo() retrieves second element whole tag contents');
test.done();
});
casper.test.begin('ClientUtils.getElementInfo() visibility tests', 4, function(test) {
casper.page.content = '<a href="plop" class="plip plup" style="display: inline"><i>paf</i></a>';
var info = casper.getElementInfo('a.plip');
test.assert(info.visible, 'ClientUtils.getElementInfo() retrieves element visibility with display inline');
casper.page.content = '<a href="plop" class="plip plup" style="display: inline-block"><i>paf</i></a>';
info = casper.getElementInfo('a.plip');
test.assert(info.visible, 'ClientUtils.getElementInfo() retrieves element visibility with display inline-block');
casper.page.content = '<a href="plop" class="plip plup" style="visibility: hidden"><i>paf</i></a>';
info = casper.getElementInfo('a.plip');
test.assertNot(info.visible, 'ClientUtils.getElementInfo() retrieves element visibility with visibility hidden');
casper.page.content = '<a href="plop" class="plip plup" style="display: none"><i>paf</i></a>';
info = casper.getElementInfo('a.plip');
test.assertNot(info.visible, 'ClientUtils.getElementInfo() retrieves element visibility with display none');
test.done();
});
......