closes #335 - dropped support for phantomjs 1.6 (1.7 & 1.8 are both supported)
Showing
6 changed files
with
10 additions
and
12 deletions
... | @@ -4,6 +4,12 @@ CasperJS Changelog | ... | @@ -4,6 +4,12 @@ CasperJS Changelog |
4 | XXXX-XX-XX, v1.0.0 | 4 | XXXX-XX-XX, v1.0.0 |
5 | ------------------ | 5 | ------------------ |
6 | 6 | ||
7 | ### Important Changes & Caveats | ||
8 | |||
9 | - PhantomJS 1.6.x support has been dropped. Both PhantomJS 1.7 & 1.8 will be supported. | ||
10 | |||
11 | ### Bugfixes & enhancements | ||
12 | |||
7 | - fixed `page.initialized` event didn't get the initialized `WebPage` instance | 13 | - fixed `page.initialized` event didn't get the initialized `WebPage` instance |
8 | - fixed a bug preventing `Casper.options.onPageInitialized()` from being called | 14 | - fixed a bug preventing `Casper.options.onPageInitialized()` from being called |
9 | - fixed [#215](https://github.com/n1k0/casperjs/issues/215) - fixed broken `--fail-fast` option creating an endless loop on error | 15 | - fixed [#215](https://github.com/n1k0/casperjs/issues/215) - fixed broken `--fail-fast` option creating an endless loop on error | ... | ... |
... | @@ -36,8 +36,8 @@ if (!phantom) { | ... | @@ -36,8 +36,8 @@ if (!phantom) { |
36 | phantom.exit(1); | 36 | phantom.exit(1); |
37 | } | 37 | } |
38 | 38 | ||
39 | if (phantom.version.major === 1 && phantom.version.minor < 6) { | 39 | if (phantom.version.major === 1 && phantom.version.minor < 7) { |
40 | console.error('CasperJS needs at least PhantomJS v1.6.0 or later.'); | 40 | console.error('CasperJS needs at least PhantomJS v1.7 or later.'); |
41 | phantom.exit(1); | 41 | phantom.exit(1); |
42 | } else { | 42 | } else { |
43 | bootstrap(window); | 43 | bootstrap(window); | ... | ... |
... | @@ -19,5 +19,5 @@ high-level functions, methods & syntaxic sugar for doing common tasks." | ... | @@ -19,5 +19,5 @@ high-level functions, methods & syntaxic sugar for doing common tasks." |
19 | s.bindir = "rubybin" | 19 | s.bindir = "rubybin" |
20 | s.executables = [ "casperjs" ] | 20 | s.executables = [ "casperjs" ] |
21 | s.license = "MIT" | 21 | s.license = "MIT" |
22 | s.requirements = [ "PhantomJS v1.6" ] | 22 | s.requirements = [ "PhantomJS v1.7" ] |
23 | end | 23 | end | ... | ... |
... | @@ -1343,9 +1343,6 @@ Casper.prototype.runStep = function runStep(step) { | ... | @@ -1343,9 +1343,6 @@ Casper.prototype.runStep = function runStep(step) { |
1343 | */ | 1343 | */ |
1344 | Casper.prototype.sendKeys = function(selector, keys, options) { | 1344 | Casper.prototype.sendKeys = function(selector, keys, options) { |
1345 | "use strict"; | 1345 | "use strict"; |
1346 | if (phantom.version.major === 1 && phantom.version.minor < 7) { | ||
1347 | throw new CasperError('sendKeys() requires PhantomJS >= 1.7'); | ||
1348 | } | ||
1349 | this.checkStarted(); | 1346 | this.checkStarted(); |
1350 | options = utils.mergeObjects({ | 1347 | options = utils.mergeObjects({ |
1351 | eventType: 'keypress' | 1348 | eventType: 'keypress' | ... | ... |
... | @@ -14,7 +14,7 @@ | ... | @@ -14,7 +14,7 @@ |
14 | } | 14 | } |
15 | ], | 15 | ], |
16 | "dependencies": { | 16 | "dependencies": { |
17 | "http://www.phantomjs.org/": "1.6" | 17 | "http://www.phantomjs.org/": "1.7" |
18 | }, | 18 | }, |
19 | "bugs": { | 19 | "bugs": { |
20 | "url": "https://github.com/n1k0/casperjs/issues" | 20 | "url": "https://github.com/n1k0/casperjs/issues" | ... | ... |
1 | /*jshint strict:false*/ | 1 | /*jshint strict:false*/ |
2 | /*global CasperError casper console phantom require*/ | 2 | /*global CasperError casper console phantom require*/ |
3 | if (phantom.version.major === 1 && phantom.version.minor < 7) { | ||
4 | casper.test.pass('Skipping tests for PhantomJS < 1.7'); | ||
5 | casper.test.done(1); | ||
6 | } | ||
7 | |||
8 | casper.start('tests/site/form.html', function() { | 3 | casper.start('tests/site/form.html', function() { |
9 | this.sendKeys('input[name="email"]', 'duke@nuk.em'); | 4 | this.sendKeys('input[name="email"]', 'duke@nuk.em'); |
10 | this.sendKeys('textarea', "Damn, I’m looking good."); | 5 | this.sendKeys('textarea', "Damn, I’m looking good."); | ... | ... |
-
Please register or sign in to post a comment