Nasty annoying memory overflow in argcv_get() that was causing random

crashes.  Couple of places check if (ptr == NULL) before free(), this is
not a bug since POSIX requires free(NULL) to be legal but on some old station
like SunOS-4 that will corrupt the freelist or crash.
Some Copyright updates.

@@ -41,17 +41,17 @@ argcv_get (const char *command, int *argc, char ***argv)
     if (command[i] == ' ')
     if (command[i] == ' ')
       (*argc)++;
       (*argc)++;
 
 
-  *argv = malloc ((*argc + 1) * sizeof (char *));
+  *argv = calloc ((*argc + 1), sizeof (char *));
 
 
   for (i = 0; i <= len; i++)
   for (i = 0; i <= len; i++)
     {
     {
       if (command[i] == ' ' || command[i] == '\0')
       if (command[i] == ' ' || command[i] == '\0')
 	{
 	{
-	  (*argv)[j] = malloc ((i-start) * sizeof (char));
-	  if (argv[j] == NULL && (i-start > 0))
+	  /* Reserve space for the null.  */
+	  (*argv)[j] = calloc ((i - start + 1),  sizeof (char));
+	  if ((*argv[j]) == NULL)
 	    return 1;
 	    return 1;
-	  strncpy ((*argv)[j], &command[start], i-start);
-	  (*argv)[j][i-start] = '\0';
+	  strncpy ((*argv)[j], &command[start], i - start);
 	  j++;
 	  j++;
 	  start = i+1;
 	  start = i+1;
 	}
 	}
@@ -68,6 +68,7 @@ int
 argcv_free (int argc, char **argv)
 argcv_free (int argc, char **argv)
 {
 {
   while (--argc >= 0)
   while (--argc >= 0)
+    if (argv[argc])
       free (argv[argc]);
       free (argv[argc]);
   free (argv);
   free (argv);
   return 1;
   return 1;

 /* GNU mailutils - a suite of utilities for electronic mail
 /* GNU mailutils - a suite of utilities for electronic mail
-   Copyright (C) 1999, 2000 Free Software Foundation, Inc.
+   Copyright (C) 1999, 2000, 2001 Free Software Foundation, Inc.
 
 
    This program is free software; you can redistribute it and/or modify
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    it under the terms of the GNU General Public License as published by

@@ -249,6 +249,7 @@ main (int argc, char **argv)
   while (1)
   while (1)
     {
     {
       int len;
       int len;
+      if (command)
 	free (command);
 	free (command);
       command = readline (prompt->set && prompt->value != NULL ? prompt->value : " ");
       command = readline (prompt->set && prompt->value != NULL ? prompt->value : " ");
       len = strlen (command);
       len = strlen (command);

 /* GNU mailutils - a suite of utilities for electronic mail
 /* GNU mailutils - a suite of utilities for electronic mail
-   Copyright (C) 1999 Free Software Foundation, Inc.
+   Copyright (C) 1999, 2001 Free Software Foundation, Inc.
 
 
    This program is free software; you can redistribute it and/or modify
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    it under the terms of the GNU General Public License as published by
@@ -45,6 +45,7 @@ mail_set (int argc, char **argv)
 	      if (entry == NULL)
 	      if (entry == NULL)
 		return 1;
 		return 1;
 	      entry->set = 0;
 	      entry->set = 0;
+	      if (entry->value)
 		free (entry->value);
 		free (entry->value);
 	    }
 	    }
 	  else if (strchr (argv[i], '=') != NULL)
 	  else if (strchr (argv[i], '=') != NULL)
@@ -63,6 +64,7 @@ mail_set (int argc, char **argv)
 	      if (entry == NULL)
 	      if (entry == NULL)
 		return 1;
 		return 1;
 	      entry->set = 1;
 	      entry->set = 1;
+	      if (entry->value)
 		free (entry->value);
 		free (entry->value);
 	      entry->value = value;
 	      entry->value = value;
 	    }
 	    }
@@ -72,6 +74,7 @@ mail_set (int argc, char **argv)
 	      if (entry == NULL)
 	      if (entry == NULL)
 		return 1;
 		return 1;
 	      entry->set = 1;
 	      entry->set = 1;
+	      if (entry->value)
 		free (entry->value);
 		free (entry->value);
 	      entry->value = NULL;
 	      entry->value = NULL;
 	    }
 	    }