* auth/sql.c, libproto/mbox/folder.c: Rename MU_READ_ERROR to

MU_ERR_READ, for consistency.

* comsat/Makefile.am (comsatd_LDADD): Add all mailbox formats.
* comsat/cfg.c: Use mu_error instead of syslog.
* comsat/comsat.c (comsat_daemon): Implement test mode.
(notify_user): Use mailbox quick access mode instead of directly
fiddling with the UNIX mailbox stream.

* include/mailutils/stream.h (MU_STREAM_QACCESS): New define.
* libproto/mbox/mbox.c: Implement _quick_get_message method.
* libproto/mbox/mbox0.h (mbox_scan1): New function.
* libproto/mbox/mboxscan.c (mbox_scan0): Split into mbox_scan0
proper and mbox_scan_internal.
(mbox_scan1): New function.
Remove unused defines.
* libsieve/load.c: Do not deallocate loaded modules.
* mail.local/main.c (set_debug_flags): Fix typo.
* mailbox/amd.c: Implement get_qid method.
(amd_append_message) Singal MU_EVT_MESSAGE_APPEND.
* mailbox/errors (MU_ERR_BADOP): New error code.
(MU_READ_ERROR): Rename to MU_ERR_READ, for consistency.
* mailbox/file_stream.c (_prog_destroy,_prog_close): Fix waiting
for the children to terminate. Do not forcefully kill them.

* mailbox/mailbox.c: Control allowed operations, depending on
MU_STREAM_QACCESS bit.

@@ -417,7 +417,7 @@ get_field (mu_sql_connection_t conn, const char *id, char **ret, int mandatory)
     {
       mu_error (_("SQL field `%s' (`%s') has NULL value"),
 		id, name ? *name : id);
-      rc = MU_READ_ERROR;
+      rc = MU_ERR_READ;
     }
 
   return rc;

@@ -26,6 +26,11 @@ comsatd_SOURCES = action.c cfg.c comsat.c comsat.h
 comsatd_LDADD = \
  ../lib/libmuaux.la\
  ${MU_LIB_MBOX}\
+ ${MU_LIB_IMAP}\
+ ${MU_LIB_POP}\
+ ${MU_LIB_NNTP}\
+ ${MU_LIB_MH}\
+ ${MU_LIB_MAILDIR}\
  ${MU_LIB_MAILUTILS}\
  @MU_COMMON_LIBRARIES@
 

@@ -110,7 +110,7 @@ netdef_parse (char *str)
   netdef = malloc (sizeof *netdef);
   if (!netdef)
     {
-      syslog (LOG_ERR, _("Out of memory"));
+      mu_error (_("Out of memory"));
       exit (1);
     }
 
@@ -135,7 +135,8 @@ read_config (const char *config_file)
   fp = fopen (config_file, "r");
   if (!fp)
     {
-      syslog (LOG_ERR, _("Cannot open config file %s: %m"), config_file);
+      mu_error (_("Cannot open config file %s: %s"), config_file,
+		mu_strerror (errno));
       return;
     }
 
@@ -162,7 +163,7 @@ read_config (const char *config_file)
       mu_argcv_get (ptr, "", NULL, &argc, &argv);
       if (argc < 2)
 	{
-	  syslog (LOG_ERR, _("%s:%d: too few fields"), config_file, line);
+	  mu_error (_("%s:%d: too few fields"), config_file, line);
 	  mu_argcv_free (argc, argv);
 	  continue;
 	}
@@ -174,7 +175,7 @@ read_config (const char *config_file)
 	  else if (strcmp (argv[1], "no") == 0)
 	    allow_biffrc = 0;
 	  else
-	    syslog (LOG_ERR, _("%s:%d: yes or no expected"), config_file, line);
+	    mu_error (_("%s:%d: yes or no expected"), config_file, line);
 	}
       else if (strcmp (argv[0], "max-requests") == 0)
 	maxrequests = strtoul (argv[1], NULL, 0);
@@ -194,7 +195,7 @@ read_config (const char *config_file)
 	    action = ACT_DENY;
 	  else
 	    {
-	      syslog (LOG_ERR, _("%s:%d: unknown keyword"), config_file, line);
+	      mu_error (_("%s:%d: unknown keyword"), config_file, line);
 	      mu_argcv_free (argc, argv);
 	      continue;
 	    }
@@ -205,7 +206,7 @@ read_config (const char *config_file)
 	      netdef_t *cur = netdef_parse (argv[i]);
 	      if (!cur)
 		{
-		  syslog (LOG_ERR, _("%s:%d: cannot parse netdef: %s"),
+		  mu_error (_("%s:%d: cannot parse netdef: %s"),
 			    config_file, line, argv[i]);
 		  continue;
 		}
@@ -221,7 +222,7 @@ read_config (const char *config_file)
 	  acl = malloc (sizeof *acl);
 	  if (!acl)
 	    {
-	      syslog (LOG_CRIT, _("Out of memory"));
+	      mu_error (_("Out of memory"));
 	      exit (1);
 	    }
 	  acl->next = NULL;

@@ -57,7 +57,8 @@ static char doc[] = "GNU comsatd";
 
 static struct argp_option options[] = 
 {
-  {"config", 'c', N_("FILE"), 0, N_("Read configuration from FILE"), 0},
+  { "config", 'c', N_("FILE"), 0, N_("Read configuration from FILE"), 0 },
+  { "test", 't', NULL, 0, N_("Run in test mode"), 0 },
   { NULL, 0, NULL, 0, NULL, 0 }
 };
 
@@ -104,7 +105,8 @@ static void comsat_init (void);
 static void comsat_daemon_init (void);
 static void comsat_daemon (int _port);
 static int comsat_main (int fd);
-static void notify_user (const char *user, const char *device, const char *path, off_t offset);
+static void notify_user (const char *user, const char *device,
+			 const char *path, mu_message_qid_t qid);
 static int find_user (const char *name, char *tty);
 static char *mailbox_path (const char *user);
 static void change_user (const char *user);
@@ -112,6 +114,7 @@ static void change_user (const char *user);
 static int xargc;
 static char **xargv;
 char *config_file = NULL;
+int test_mode;
 
 static error_t
 comsatd_parse_opt (int key, char *arg, struct argp_state *state)
@@ -126,6 +129,10 @@ comsatd_parse_opt (int key, char *arg, struct argp_state *state)
       config_file = arg;
       break;
 
+    case 't':
+      test_mode = 1;
+      break;
+      
     default:
       return ARGP_ERR_UNKNOWN;
     }
@@ -134,20 +141,59 @@ comsatd_parse_opt (int key, char *arg, struct argp_state *state)
 
 
 int
-main(int argc, char **argv)
+main (int argc, char **argv)
 {
   int c;
+  int ind;
   
   /* Native Language Support */
   mu_init_nls ();
 
   mu_argp_init (program_version, NULL);
   mu_argp_parse (&argp, &argc, &argv, 0, comsat_argp_capa,
-		 NULL, &daemon_param);
+		 &ind, &daemon_param);
+
+  argc -= ind;
+  argv += ind;
+  
+  if (test_mode)
+    {
+      char *user, *url, *qid;
+      
+      comsat_init ();
+      if (config_file)
+	read_config (config_file);
+      if (argc == 0)
+	exit (0);
+      if (argc < 2 || argc > 2)
+	{
+	  mu_error (_("Mailbox URL and message QID are required in test mode"));
+	  exit (EXIT_FAILURE);
+	}
+
+      user = getenv ("LOGNAME");
+      if (!user)
+	{
+	  user = getenv ("USER");
+	  if (!user)
+	    {
+	      struct passwd *pw = getpwuid (getuid ());
+	      if (!pw)
+		{
+		  mu_error (_("Cannot determine user name"));
+		  exit (EXIT_FAILURE);
+		}
+	      user = pw->pw_name;
+	    }
+	}
+		  
+      notify_user (user, "/dev/tty", argv[0], argv[1]);
+      exit (0);
+    }
   
   if (daemon_param.timeout > 0 && daemon_param.mode == MODE_DAEMON)
     {
-      fprintf (stderr, _("--timeout and --daemon are incompatible\n"));
+      mu_error (_("--timeout and --daemon are incompatible"));
       exit (EXIT_FAILURE);
     }
 
@@ -194,7 +240,8 @@ sig_hup (int sig)
 void
 comsat_init ()
 {
-  mu_registrar_record (mu_path_record);
+  /* Register mailbox formats */
+  mu_register_all_mbox_formats ();
 
   gethostname (hostname, sizeof hostname);
 
@@ -324,9 +371,9 @@ comsat_main (int fd)
   char buffer[216]; /*FIXME: Arbitrary size */
   pid_t pid;
   char tty[MAX_TTY_SIZE];
-  char *p, *endp;
-  size_t offset;
+  char *p;
   char *path = NULL;
+  mu_message_qid_t qid;
   
   len = sizeof sin_from;
   rdlen = recvfrom (fd, buffer, sizeof buffer, 0,
@@ -362,18 +409,7 @@ comsat_main (int fd)
     }
   *p++ = 0;
 
-  offset = strtoul (p, &endp, 0);
-  switch (*endp)
-    {
-    case 0:
-      break;
-    case ':':
-      path = endp+1;
-      break;
-    default:
-      if (!isspace (*endp))
-	syslog (LOG_ERR, _("Malformed input: %s@%s (near %s)"), buffer, p, endp);
-    }
+  qid = p;
   
   if (find_user (buffer, tty) != SUCCESS)
     return 0;
@@ -400,7 +436,7 @@ comsat_main (int fd)
     }
 
   /* Child: do actual I/O */
-  notify_user (buffer, tty, path, offset);
+  notify_user (buffer, tty, path, qid);
   exit (0);
 }
 
@@ -423,17 +459,14 @@ get_newline_str (FILE *fp)
 /* NOTE: Do not bother to free allocated memory, as the program exits
    immediately after executing this */
 static void
-notify_user (const char *user, const char *device, const char *path, off_t offset)
+notify_user (const char *user, const char *device, const char *path,
+	     mu_message_qid_t qid)
 {
   FILE *fp;
   const char *cr;
-  char *blurb;
-  mu_mailbox_t mbox = NULL, tmp = NULL;
+  mu_mailbox_t mbox = NULL;
   mu_message_t msg;
-  mu_stream_t stream = NULL;
   int status;
-  off_t size;
-  size_t count, n;
 
   change_user (user);
   if ((fp = fopen (device, "w")) == NULL)
@@ -452,56 +485,21 @@ notify_user (const char *user, const char *device, const char *path, off_t offse
     }
 
   if ((status = mu_mailbox_create (&mbox, path)) != 0
-      || (status = mu_mailbox_open (mbox, MU_STREAM_READ)) != 0)
+      || (status = mu_mailbox_open (mbox, MU_STREAM_READ|MU_STREAM_QACCESS)) != 0)
     {
       syslog (LOG_ERR, _("Cannot open mailbox %s: %s"),
 	      path, mu_strerror (status));
       return;
     }
 
-  if ((status = mu_mailbox_get_stream (mbox, &stream)))
-    {
-      syslog (LOG_ERR, _("Cannot get stream for mailbox %s: %s"),
-	      path, mu_strerror (status));
-      return;
-    }
-
-  if ((status = mu_stream_size (stream, &size)))
-    {
-      syslog (LOG_ERR, _("Cannot get stream size (mailbox %s): %s"),
-	      path, mu_strerror (status));
-      return;
-    }
-
-  /* Read headers */
-  size -= offset;
-  blurb = malloc (size + 1);
-  if (!blurb)
-    return;
-
-  mu_stream_read (stream, blurb, size, offset, &n);
-  blurb[size] = 0;
-
-  if ((status = mu_mailbox_create (&tmp, "/dev/null")) != 0
-      || (status = mu_mailbox_open (tmp, MU_STREAM_READ)) != 0)
-    {
-      syslog (LOG_ERR, _("Cannot create temporary mailbox: %s"),
-	      mu_strerror (status));
-      return;
-    }
-
-  if ((status = mu_memory_stream_create (&stream, 0, 0)))
+  status = mu_mailbox_quick_get_message (mbox, qid, &msg);
+  if (status)
     {
-      syslog (LOG_ERR, _("Cannot create temporary stream: %s"),
-	      mu_strerror (status));
-      return;
+      syslog (LOG_ERR, _("Cannot get message (mailbox %s, qid %s): %s"),
+	      path, qid, mu_strerror (status));
+      return; /* FIXME: Notify the user, anyway */
     }
 
-  mu_stream_write (stream, blurb, size, 0, &count);
-  mu_mailbox_set_stream (tmp, stream);
-  mu_mailbox_messages_count (tmp, &count);
-  mu_mailbox_get_message (tmp, 1, &msg);
-
   run_user_action (fp, cr, msg);
   fclose (fp);
 }

@@ -39,6 +39,8 @@ extern "C" { /*}*/
 #define MU_STREAM_NO_CLOSE    0x00000100
 #define MU_STREAM_ALLOW_LINKS 0x00000200
 #define MU_STREAM_NONLOCK     0x00000400
+/* This one affects only mailboxes */  
+#define MU_STREAM_QACCESS     0x00000800  
 
 /* Functions useful to users of the pre-defined stream types. */
 

@@ -358,7 +358,7 @@ list_helper (struct search_data *data,
 	  break;
 
 	case GLOB_ABORTED:
-	  status = MU_READ_ERROR;
+	  status = MU_ERR_READ;
 	  break;
 
 	case GLOB_NOMATCH:

@@ -35,6 +35,9 @@ static void mbox_destroy (mu_mailbox_t);
 static int mbox_open                  (mu_mailbox_t, int);
 static int mbox_close                 (mu_mailbox_t);
 static int mbox_get_message           (mu_mailbox_t, size_t, mu_message_t *);
+static int mbox_quick_get_message (mu_mailbox_t, mu_message_qid_t,
+				   mu_message_t *);
+
 /* static int mbox_get_message_by_uid    (mu_mailbox_t, size_t, mu_message_t *); */
 static int mbox_append_message        (mu_mailbox_t, mu_message_t);
 static int mbox_messages_count        (mu_mailbox_t, size_t *);
@@ -136,6 +139,7 @@ _mailbox_mbox_init (mu_mailbox_t mailbox)
   mailbox->_sync = mbox_sync;
   mailbox->_uidvalidity = mbox_uidvalidity;
   mailbox->_uidnext = mbox_uidnext;
+  mailbox->_quick_get_message = mbox_quick_get_message;
 
   mailbox->_scan = mbox_scan;
   mailbox->_is_updated = mbox_is_updated;
@@ -1065,45 +1069,10 @@ mbox_envelope_sender (mu_envelope_t envelope, char *buf, size_t len,
 }
 
 static int
-mbox_get_message (mu_mailbox_t mailbox, size_t msgno, mu_message_t *pmsg)
+new_message (mu_mailbox_t mailbox, mbox_message_t mum, mu_message_t *pmsg)
 {
   int status;
-  mbox_data_t mud = mailbox->data;
-  mbox_message_t mum;
-  mu_message_t msg = NULL;
-
-  /* Sanity checks.  */
-  if (pmsg == NULL)
-    return MU_ERR_OUT_PTR_NULL;
-  if (mud == NULL)
-    return EINVAL;
-
-  /* If we did not start a scanning yet do it now.  */
-  if (mud->messages_count == 0)
-    {
-      status = mbox_scan0 (mailbox, 1, NULL, 0);
-      if (status != 0)
-	return status;
-    }
-
-  /* Second sanity: check the message number.  */
-  if (!(mud->messages_count > 0
-	&& msgno > 0
-	&& msgno <= mud->messages_count))
-    return EINVAL;
-
-  mum = mud->umessages[msgno - 1];
-
-  /* Check if we already have it.  */
-  if (mum->message)
-    {
-      if (pmsg)
-	*pmsg = mum->message;
-      return 0;
-    }
-
-  MAILBOX_DEBUG2 (mailbox, MU_DEBUG_TRACE, "mbox_get_message (%s, %d)\n",
-		  mud->name, msgno);
+  mu_message_t msg;
 
   /* Get an empty message struct.  */
   status = mu_message_create (&msg, mum);
@@ -1185,10 +1154,110 @@ mbox_get_message (mu_mailbox_t mailbox, size_t msgno, mu_message_t *pmsg)
   mu_message_set_mailbox (msg, mailbox, mum);
 
   *pmsg = msg;
+  
+  return 0;
+}  
+
+static int
+mbox_get_message (mu_mailbox_t mailbox, size_t msgno, mu_message_t *pmsg)
+{
+  int status;
+  mbox_data_t mud = mailbox->data;
+  mbox_message_t mum;
+
+  /* Sanity checks.  */
+  if (pmsg == NULL)
+    return MU_ERR_OUT_PTR_NULL;
+  if (mud == NULL)
+    return EINVAL;
+
+  /* If we did not start a scanning yet do it now.  */
+  if (mud->messages_count == 0)
+    {
+      status = mbox_scan0 (mailbox, 1, NULL, 0);
+      if (status != 0)
+	return status;
+    }
+
+  /* Second sanity: check the message number.  */
+  if (!(mud->messages_count > 0
+	&& msgno > 0
+	&& msgno <= mud->messages_count))
+    return EINVAL;
+
+  mum = mud->umessages[msgno - 1];
+
+  /* Check if we already have it.  */
+  if (mum->message)
+    {
+      if (pmsg)
+	*pmsg = mum->message;
+      return 0;
+    }
+
+  MAILBOX_DEBUG2 (mailbox, MU_DEBUG_TRACE, "mbox_get_message (%s, %d)\n",
+		  mud->name, msgno);
+
+  return new_message (mailbox, mum, pmsg);
+}
+
+static int
+qid2off (mu_message_qid_t qid, mu_off_t *pret)
+{
+  mu_off_t ret = 0;
+  for (;*qid; qid++)
+    {
+      if (!('0' <= *qid && *qid <= '9'))
+	return 1;
+      ret = ret * 10 + *qid - '0';
+    }
+  *pret = ret;
   return 0;
 }
       
 static int
+mbox_quick_get_message (mu_mailbox_t mailbox, mu_message_qid_t qid,
+			mu_message_t *pmsg)
+{
+  int status;
+  mbox_data_t mud = mailbox->data;
+  mbox_message_t mum;
+  mu_off_t offset;
+  
+  if (mailbox == NULL || qid2off (qid, &offset)
+      || !(mailbox->flags & MU_STREAM_QACCESS))
+    return EINVAL;
+
+  if (mud->messages_count == 0)
+    {
+      status = mbox_scan1 (mailbox, offset, 0);
+      if (status != 0)
+	return status;
+    }
+
+  /* Quick access mode retrieves only one message */
+  mum = mud->umessages[0]; 
+
+  /* Check if we already have it and verify if it is the right one. */
+  if (mum->message)
+    {
+      char *vqid;
+      status = mu_message_get_qid (mum->message, &vqid);
+      if (status)
+	return status;
+      status = strcmp (qid, vqid);
+      free (vqid);
+      if (status)
+	return MU_ERR_EXISTS;
+      if (pmsg)
+	*pmsg = mum->message;
+      return 0;
+    }
+
+  return new_message (mailbox, mum, pmsg);
+}
+     
+static int
 mbox_append_message (mu_mailbox_t mailbox, mu_message_t msg)
 {
   int status = 0;

@@ -124,6 +124,9 @@ struct _mbox_data
 
 int mbox_scan0 (mu_mailbox_t mailbox, size_t msgno, size_t *pcount,
 		int do_notif);
+int mbox_scan1 (mu_mailbox_t mailbox, mu_off_t offset, int do_notif);
+
 #ifdef WITH_PTHREAD
 void mbox_cleanup (void *arg);
 #endif
+

@@ -31,12 +31,15 @@
 
 typedef int (*sieve_module_init_t) (mu_sieve_machine_t mach);
 
+#if 0
+/* FIXME: See comment below */ 
 static void
 _free_loaded_module (void *data)
 {
   lt_dlclose ((lt_dlhandle)data);
   lt_dlexit ();
 }
+#endif
 
 static lt_dlhandle
 load_module (mu_sieve_machine_t mach, const char *name)
@@ -54,7 +57,13 @@ load_module (mu_sieve_machine_t mach, const char *name)
       if (init)
 	{
 	  init (mach);
-	  mu_sieve_machine_add_destructor (mach, _free_loaded_module, handle);
+	  /* FIXME: We used to have this:
+  	       mu_sieve_machine_add_destructor (mach, _free_loaded_module,
+ 	                                        handle);
+             However, unloading modules can lead to random segfaults in
+	     case they allocated any global-access data (e.g. mach->msg).
+	     In particular, this was the case with extensions/pipe.c. 
+	  */
 	  return handle;
 	}
       else

@@ -131,7 +131,7 @@ char *saved_envelope;  /* A hack to spare mu_envelope_ calls */
 static void
 set_debug_flags (const mu_cfg_locus_t *locus, const char *arg)
 {
-  for (; *arg; arg++);
+  for (; *arg; arg++)
     {
       switch (*arg)
 	{

@@ -380,6 +380,16 @@ amd_close (mu_mailbox_t mailbox)
   return 0;
 }
 
+static int
+amd_message_qid (mu_message_t msg, mu_message_qid_t *pqid)
+{
+  struct _amd_message *mhm = mu_message_get_owner (msg);
+  
+  *pqid = mhm->amd->msg_file_name (mhm,
+				   mhm->attr_flags & MU_ATTRIBUTE_DELETED);
+  return 0;
+}
+
 struct _amd_message *
 _amd_get_message (struct _amd_data *amd, size_t msgno)
 {
@@ -480,6 +490,7 @@ _amd_attach_message (mu_mailbox_t mailbox, struct _amd_message *mhm,
   /* Set the UID.  */
   if (mhm->amd->message_uid)
     mu_message_set_uid (msg, mhm->amd->message_uid, mhm);
+  mu_message_set_qid (msg, amd_message_qid, mhm);
   
   /* Attach the message to the mailbox mbox data.  */
   mhm->message = msg;
@@ -726,6 +737,14 @@ amd_append_message (mu_mailbox_t mailbox, mu_message_t msg)
   if (amd->msg_finish_delivery)
     amd->msg_finish_delivery (amd, mhm);
 
+  if (mailbox->observable)
+    {
+      char *qid = amd->msg_file_name (mhm,
+				      mhm->attr_flags & MU_ATTRIBUTE_DELETED);
+      mu_observable_notify (mailbox->observable, MU_EVT_MESSAGE_APPEND, qid);
+      free (qid);
+    }
+  
   return status;
 }
 

@@ -80,5 +80,6 @@ MU_ERR_BAD_COLUMN           _("Bad column address")
 MU_ERR_NO_RESULT            _("No result from the previous query available")
 MU_ERR_NO_INTERFACE         _("No such interface")
 
+MU_ERR_BADOP                _("Inappropriate operation for this mode")
 MU_ERR_BAD_FILENAME         _("Badly formed file or directory name")
-MU_READ_ERROR               _("Read error")
+MU_ERR_READ                 _("Read error")

@@ -704,28 +704,6 @@ _prog_stream_unregister (struct _prog_stream *stream)
   mu_list_remove (prog_stream_list, stream);
 }
 
-static int
-_prog_waitpid (void *item, void *data MU_ARG_UNUSED)
-{
-  struct _prog_stream *str = item;
-  int status;
-  if (str->pid > 0)
-    {
-      if (waitpid (str->pid, &str->status, WNOHANG) == str->pid)
-	str->pid = -1;
-    }
-  if (str->writer_pid > 0)
-    waitpid (str->writer_pid, &status, WNOHANG);
-  return 0;
-}
-
-static void
-_prog_stream_wait (struct _prog_stream *fs)
-{
-  if (fs->pid > 0)
-    waitpid (fs->pid, &fs->status, 0);
-}
-
 #if defined (HAVE_SYSCONF) && defined (_SC_OPEN_MAX)
 # define getmaxfd() sysconf (_SC_OPEN_MAX)
 #elif defined (HAVE_GETDTABLESIZE)
@@ -841,23 +819,34 @@ start_program_filter (pid_t *pid, int *p, int argc, char **argv,
 }
 
 static void
+_prog_wait (pid_t pid, int *pstatus)
+{
+  if (pid > 0)
+    {
+      pid_t t;
+      do
+	t = waitpid (pid, pstatus, 0);
+      while (t == -1 && errno == EINTR);
+    }
+}
+
+static void
 _prog_destroy (mu_stream_t stream)
 {
   struct _prog_stream *fs = mu_stream_get_owner (stream);
+  int status;
+    
   mu_argcv_free (fs->argc, fs->argv);
   if (fs->in)
     mu_stream_destroy (&fs->in, mu_stream_get_owner (fs->in));
   if (fs->out)
     mu_stream_destroy (&fs->out, mu_stream_get_owner (fs->out));
-  if (fs->pid > 0)
-    {
-      kill (fs->pid, SIGTERM);
-      mu_list_do (prog_stream_list, _prog_waitpid, NULL);
-      kill (fs->pid, SIGKILL);
-      if (fs->writer_pid > 0)
-	kill (fs->writer_pid, SIGKILL);
-      mu_list_do (prog_stream_list, _prog_waitpid, NULL);
-    }
+  
+  _prog_wait (fs->pid, &fs->status);
+  fs->pid = -1;
+  _prog_wait (fs->writer_pid, &status);
+  fs->writer_pid = -1;
+  
   _prog_stream_unregister (fs);
 }
 
@@ -865,6 +854,7 @@ static int
 _prog_close (mu_stream_t stream)
 {
   struct _prog_stream *fs = mu_stream_get_owner (stream);
+  int status;
   
   if (!stream)
     return EINVAL;
@@ -875,7 +865,10 @@ _prog_close (mu_stream_t stream)
   mu_stream_close (fs->out);
   mu_stream_destroy (&fs->out, mu_stream_get_owner (fs->out));
 
-  _prog_stream_wait (fs);
+  _prog_wait (fs->pid, &fs->status);
+  fs->pid = -1;
+  _prog_wait (fs->writer_pid, &status);
+  fs->writer_pid = -1;
   
   mu_stream_close (fs->in);
   mu_stream_destroy (&fs->in, mu_stream_get_owner (fs->in));

@@ -174,7 +174,8 @@ mu_mailbox_destroy (mu_mailbox_t *pmbox)
       /* Notify the observers.  */
       if (mbox->observable)
 	{
-	  mu_observable_notify (mbox->observable, MU_EVT_MAILBOX_DESTROY, mbox);
+	  mu_observable_notify (mbox->observable, MU_EVT_MAILBOX_DESTROY,
+				mbox);
 	  mu_observable_destroy (&mbox->observable, mbox);
 	}
 
@@ -223,6 +224,13 @@ mu_mailbox_open (mu_mailbox_t mbox, int flag)
 {
   if (mbox == NULL || mbox->_open == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (flag & MU_STREAM_QACCESS)
+    {
+      /* Quick access mailboxes are read-only */
+      if (flag & (MU_STREAM_WRITE | MU_STREAM_RDWR
+		  | MU_STREAM_APPEND | MU_STREAM_CREAT))
+	return EINVAL; /* FIXME: Better error code, please? */
+    }
   return mbox->_open (mbox, flag);
 }
 
@@ -284,6 +292,8 @@ mu_mailbox_get_message (mu_mailbox_t mbox, size_t msgno,  mu_message_t *pmsg)
 {
   if (mbox == NULL || mbox->_get_message == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   return mbox->_get_message (mbox, msgno, pmsg);
 }
 
@@ -293,6 +303,8 @@ mu_mailbox_quick_get_message (mu_mailbox_t mbox, mu_message_qid_t qid,
 {
   if (mbox == NULL || mbox->_quick_get_message == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (!(mbox->flags & MU_STREAM_QACCESS))
+    return MU_ERR_BADOP;
   return mbox->_quick_get_message (mbox, qid, pmsg);
 }
 
@@ -301,6 +313,8 @@ mu_mailbox_messages_count (mu_mailbox_t mbox, size_t *num)
 {
   if (mbox == NULL || mbox->_messages_count == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   return mbox->_messages_count (mbox, num);
 }
 
@@ -309,6 +323,8 @@ mu_mailbox_messages_recent (mu_mailbox_t mbox, size_t *num)
 {
   if (mbox == NULL || mbox->_messages_recent == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   return mbox->_messages_recent (mbox, num);
 }
 
@@ -317,6 +333,8 @@ mu_mailbox_message_unseen (mu_mailbox_t mbox, size_t *num)
 {
   if (mbox == NULL || mbox->_message_unseen == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   return mbox->_message_unseen (mbox, num);
 }
 
@@ -356,6 +374,8 @@ mu_mailbox_is_updated (mu_mailbox_t mbox)
 {
   if (mbox == NULL || mbox->_is_updated == NULL)
     return 1;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return 1;
   return mbox->_is_updated (mbox);
 }
 
@@ -364,6 +384,8 @@ mu_mailbox_scan (mu_mailbox_t mbox, size_t msgno, size_t *pcount)
 {
   if (mbox == NULL || mbox->_scan == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   return mbox->_scan (mbox, msgno, pcount);
 }
 
@@ -373,6 +395,8 @@ mu_mailbox_get_size (mu_mailbox_t mbox, mu_off_t *psize)
   int status;
   if (mbox == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   if (mbox->_get_size == NULL
       || (status = mbox->_get_size (mbox, psize)) == ENOSYS)
     {
@@ -405,6 +429,8 @@ mu_mailbox_uidvalidity (mu_mailbox_t mbox, unsigned long *pvalid)
 {
   if (mbox == NULL || mbox->_uidvalidity == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   return mbox->_uidvalidity (mbox, pvalid);
 }
 
@@ -413,6 +439,8 @@ mu_mailbox_uidnext (mu_mailbox_t mbox, size_t *puidnext)
 {
   if (mbox == NULL || mbox->_uidnext == NULL)
     return MU_ERR_EMPTY_VFN;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   return mbox->_uidnext (mbox, puidnext);
 }
 
@@ -455,6 +483,8 @@ mu_mailbox_set_stream (mu_mailbox_t mbox, mu_stream_t stream)
 {
   if (mbox == NULL)
     return MU_ERR_MBX_NULL;
+  if (mbox->flags & MU_STREAM_QACCESS)
+    return MU_ERR_BADOP;
   if (mbox->stream)
     mu_stream_destroy (&mbox->stream, mbox);
   mbox->stream = stream;