Skip to content

John McEleney / mailutils

Go to a project
Toggle navigation
Toggle navigation pinning
Commit f5532b4a f5532b4a7485a2c098a367917952a7518de8d408 by Alain Magloire
Options

* mailbox/pop/pop3_lista.c: Destroy the list on error. 

	* mailbox/pop/pop3_uidla.c: Destroy the list on error.
1 parent ae5a9652
Inline Side-by-side
Showing 2 changed files with 19 additions and 5 deletions
/* GNU Mailutils -- a suite of utilities for electronic mail
Copyright (C) 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright (C) 1999, 2000, 2001, 2004 Free Software Foundation, Inc.
This library is free software; you can redistribute it and/or
modify it under the terms of the GNU Lesser General Public
......@@ -65,12 +65,18 @@ mu_pop3_list_all (mu_pop3_t pop3, list_t *plist)
But do not use the stack and malloc. */
char *lista;
size_t n = 0;
lista = malloc (512);
if (lista == NULL)
{
MU_POP3_CHECK_ERROR(pop3, ENOMEM);
/* MU_POP3_CHECK_ERROR(pop3, ENOMEM);
Do not use the macro we need to clear the list if errors. */
pop3->io.ptr = pop3->io.buf;
pop3->state = MU_POP3_ERROR;
list_destroy (plist);
return ENOMEM;
}
while ((status = mu_pop3_readline (pop3, lista, 512, &n)) == 0 && n > 0)
{
/* Nuke the trailing newline */
......
......@@ -64,12 +64,20 @@ mu_pop3_uidl_all (mu_pop3_t pop3, list_t *plist)
But do not use the stack and malloc. */
char *uidla;
size_t n = 0;
uidla = malloc (512);
if (uidla == NULL)
{
MU_POP3_CHECK_ERROR(pop3, ENOMEM);
/* MU_POP3_CHECK_ERROR(pop3, ENOMEM)
Do not use the macro since we have to remove the list
if things go wrong.
*/
pop3->io.ptr = pop3->io.buf;
pop3->state = MU_POP3_ERROR;
list_destroy (plist);
return ENOMEM;
}
while ((status = mu_pop3_readline (pop3, uidla, 512, &n)) == 0 && n > 0)
{
/* Nuke the trailing newline */
......