Skip to content

John McEleney / mailutils

Go to a project
Toggle navigation
Toggle navigation pinning
Switch branch/tag
  1. 01 Nov, 2001 17 commits
  3. 31 Oct, 2001 2 commits
  5. 30 Oct, 2001 8 commits
  7. 26 Oct, 2001 6 commits
  9. 25 Oct, 2001 3 commits
  11. 24 Oct, 2001 4 commits
    • Typos in Changelog. · 89c7c751
      Alain Magloire authored
    • The message_t object makes no guaranty about the size and the lines · d3fc411b 
      	that it returns, if it is pointing to non-local file messages,
	i.e POP3, IMAP4, the entire message may not have been dowloaded yet.
	IMAP is very susceptible on the size, example:
	 A003 APPEND saved-messages (\Seen) {310}
	(1) If the IMAP4 server does not get the right size advertise in the
	string literal, it will misbehave.
	(2) Since we are assuming that the message will be in (unix)native
	file system format meaning ending with NEWLINE, we will have
	to do some calculations about the RFC822.SIZE of the message.
	(3) As pointed about, it is not possible to rely on message_size()
	nor message_lines() to return the right count and even missing by
	one can be deadly.
	So we download the message to a floating message to guaranty that
	we know the exact size when transmitting it back the IMAP server,
	this is the only sane thing to do IMHO.  We could always
	be smart; check if the message is local (i.e from the local file
	system: mbox, mh, etc ..) and was not modified.  If those two
	requirements are true we can assume that the sizes/lines are right.
	But for now do it simple, and create a temporary file/message_t.

	* mailbox/mbx_imap.c (imap_append_message):  If the message
	is from the same IMAP server optimize by doing COPY.  If not
	call imap_append_message0() save the original message to a
	floating message i.e. file, and use that floating message for
	the append.  Temporary message is destroyed when finish.
	The drawback is this function is no long nonblocking safe.
      Alain Magloire authored
    • oops forgot mutil.c · 7b535b57 
      	* mailbox/mutil.c: Add <errno.h> if we use errno directly.
	(mu_get_user_email): size not used, nuked.
      Alain Magloire authored
    • * mailbox/body.c: body_lines () nd body_size () were not · b845fd2c 
      	properly overriden given the wrong size and line number, fixed.
	* mailbox/mbx_imap.c (mailbox_imap_close): Not to send another SELECT
	but rather just close the mailbox if not selected.
	(imap_scan0): If there is no messages in the mailbox no need to
	send the FETCH 1:*.
	* mailbox/message.c (message_is_modified): Protect against null
	pointer.

	* TODO: Some stuff todo 8).
      Alain Magloire authored