Skip to content

John McEleney / mailutils

Go to a project
Toggle navigation
Toggle navigation pinning
Switch branch/tag
  1. 24 Oct, 2011 1 commit
  3. 23 Oct, 2011 2 commits
  5. 22 Oct, 2011 2 commits
    • Fixes in the testsuite & some minor fixes. · 09372ddf 
      * comsat/comsat.c (main): Use real UID to determine user name. Don't
rely on environment variables.
* maidag/util.c (maidag_error): Re-initialize va_list before reusing it.
* mh/ali.c (ali_print_name_list): Change printing loop to correctly
handle empty lists.
* mh/mh_whatnow.c (quit): Print newline before returning.

* comsat/tests/testsuite.at: Skip tests if run as root.
* maidag/tests/forward.at: Skip test if run as root.
* mh/tests/ali.at: Ignore comment lines in /etc/passwd and /etc/group.
Make sure awk is run with a valid stdin.  Some implementations
(true awk, in particular) try to close stdin even if it is not used and
bail out if unable to do so.
* mh/tests/atlocal.in (mimeflt): Make sure awk is run with a valid
stdin (see above).
* mh/tests/anno.at: Always use semicolon before closing curly brace in
sed expressions.
* mh/tests/mark.at: Likewise.
* mh/tests/pick.at: Likewise.
* testsuite/testsuite.inc: Likewise.
* mh/tests/comp.at: Reflect changes to mh_whatnow.c.
* mh/tests/mhn.at: Don't rely on a particular tar output format.
      Sergey Poznyakoff authored
    • Make all status flags permanent. · 2f34f8ae 
      * include/mailutils/attribute.h (MU_STATUS_BUF_SIZE): Add more status letters.
* libmailutils/mailbox/attribute.c (flagtrans): Keep the same ordering as
in attribute.h.  Add missing attributes.

* imap4d/select.c (imap4d_select_status): All flags are now permanent.
* imap4d/testsuite/imap4d/IDEF0955.exp: Reflect changes in PERMANENTFLAGS.
* imap4d/testsuite/imap4d/IDEF0956.exp: Likewise.
* imap4d/testsuite/imap4d/append.exp: Likewise.
* imap4d/testsuite/imap4d/create.exp: Likewise.
* imap4d/testsuite/imap4d/examine.exp: Likewise.
* imap4d/testsuite/imap4d/expunge.exp: Likewise.
* imap4d/testsuite/imap4d/fetch.exp: Likewise.
* imap4d/testsuite/imap4d/search.exp: Likewise.
      Sergey Poznyakoff authored
  7. 21 Oct, 2011 3 commits
  9. 20 Oct, 2011 2 commits
    • Change attribute handling in Maildir format. · fa3be4ba 
      * include/mailutils/message.h (MU_MSG_ATTRIBUTE_MODIFIED)
(MU_MSG_HEADER_MODIFIED,MU_MSG_BODY_MODIFIED): New flags.
* libmailutils/mailbox/message.c (mu_message_is_modified): Return
a bitmask from the above values.
* libmailutils/property/create.c (mu_property_create_init): Return
error code.

* include/mailutils/sys/amd.h (_amd_data) <chattr_msg>
<capabilities, prop>: New members.
<uidvalidity>: Remove.
* libmailutils/base/amd.c: Use MH-style proplist to keep
the mailbox properties: uidvalidity, last uid and to
cache its size.
Store message attributes in the message header only if the
mailbox implementation is unable to keep them elsewhere.
Use chattr_msg method (if provided) to flush changes in
message attributes.

* libproto/maildir/folder.c (_maildir_list_p): Ignore .mh* and .mu* files.
* libproto/mh/folder.c (_mh_list_p): Likewise.
* libproto/maildir/mbox.c: Implement all Maildir flags (except P).
Implement the chattr_msg method.
* libproto/mh/mbox.c: Remove special handling for uidvalidity.
* mh/tests/folder.at: Ignore .mu-prop in directory listings.
      Sergey Poznyakoff authored
    • Bugfix. · f697923a 
      * libmu_cfg/tls.c (cb2_safety_checks): Fix handling of "all" and "none".
* maidag/maidag.c (cb2_forward_file_checks): Likewise.
* maidag/forward.c (maidag_forward): Handle MU_ERR_EXISTS return properly.
      Sergey Poznyakoff authored
  11. 18 Oct, 2011 1 commit
  13. 17 Oct, 2011 1 commit
    • Provide a mechanism for configurable file safety checking. · dfed0be6 
      Use it in maidag (.forward file safety) and in libmu_auth (TLS files).

* include/mailutils/tls.h (mu_tls_module_config): New members
for safety check flags.
* include/mailutils/util.h (MU_FILE_SAFETY_NONE,MU_FILE_SAFETY_ALL)
(MU_FILE_SAFETY_OWNER_MISMATCH)
(MU_FILE_SAFETY_GROUP_WRITABLE,MU_FILE_SAFETY_WORLD_WRITABLE)
(MU_FILE_SAFETY_GROUP_READABLE,MU_FILE_SAFETY_WORLD_READABLE)
(MU_FILE_SAFETY_LINKED_WRDIR)
(MU_FILE_SAFETY_DIR_IWGRP,MU_FILE_SAFETY_DIR_IWOTH): New constants.
(mu_file_safety_check,mu_file_safety_name_to_code)
(mu_file_safety_name_to_error): New protos.
* libmailutils/base/checkperms.c: New file.
* libmailutils/base/Makefile.am (libbase_la_SOURCES): Add checkperms.c.
* libmailutils/diag/errors: Add new error codes.
(MU_ERR_UNSAFE_PERMS): change description wording.
* libmu_auth/tls.c (mu_check_tls_environment): Use mu_file_safety_check.
* libmu_cfg/tls.c (tls_settings): Initialize.
(mu_tls_param): New configuration file statements:
key-file-safety-checks, cert-file-safety-checks, ca-file-safety-checks.
* maidag/forward.c (maidag_forward): Use mu_file_safety_check.
* maidag/maidag.c (cb2_forward_file_checks): Use
mu_file_safety_name_to_code.
      Sergey Poznyakoff authored
  15. 16 Oct, 2011 2 commits
  17. 15 Oct, 2011 2 commits
    • Bugfixes. · 85032d0e 
      * libmailutils/base/amd.c (amd_open): Return error if the mailbox
cannot be opened for the required access permissions.
(amd_message_stream_open): Fix condition for
determining r/w access.
* mh/mh_list.c (eval_extras): Break the loop if mu_header_aget_field_name
fails.
      Sergey Poznyakoff authored
    • imap4d: fix returned INTERNALDATE and date searches. · 5e5b68fd 
      INTERNALDATE now includes a meaningful timezone information (it
used to return +0000).

Date searches disregard the time and timezone of the INTERNALDATE
or Date: header, as mandated by RFC 3501.

* libmailutils/base/date.c (mu_parse_ctime_date_time): In the absence
of TZ in ctime strings, return local time zone.

* imap4d/io.c (imap4d_tokbuf_getline): Kill trailing whitespace.

* imap4d/util.c (adjust_tm): New function.
(util_parse_internal_date)
(util_parse_822_date)
(util_parse_ctime_date): Take three arguments, the third one controlling
what information to return. All uses updated.
* imap4d/fetch.c (_frt_internaldate): Return meaningful timezone.
If all else fails, use local TZ.
* imap4d/imap4d.h (datetime_parse_mode): New enum.
(util_parse_internal_date)
(util_parse_822_date)
(util_parse_ctime_date): Change signature.
* imap4d/search.c (parse_simple_key)
(_header_date,cond_before,cond_on,cond_since): Use datetime_date_only mode.

* testsuite/spool/search.mbox: New file.
* testsuite/spool/DISTFILES: Add search.mbox
* imap4d/testsuite/lib/imap4d.exp (imap4d_start): New option -mbox.
* imap4d/testsuite/imap4d/search.exp: Rewrite.

* imap4d/testsuite/imap4d/create.exp: Account for TZ part in internaldate
strings, which may vary.
* imap4d/testsuite/imap4d/fetch.exp: Likewise.
* imap4d/testsuite/imap4d/list.exp: List the new mailbox.
      Sergey Poznyakoff authored
  19. 22 Sep, 2011 1 commit
    • Bugfix · e759db27 
      * libmailutils/filter/crlfflt.c (_crlf_encoder): Reset state to
initial if any character other than \r and \n is read.
      Sergey Poznyakoff authored
  21. 09 Sep, 2011 3 commits
  23. 29 Aug, 2011 3 commits
  25. 28 Aug, 2011 1 commit
  27. 27 Aug, 2011 1 commit
  29. 26 Aug, 2011 1 commit
    • Improve mime support, introduce ref/unref functions for mu_message_t and mu_mime_t. · a71c4b6b 
      * include/mailutils/message.h (mu_message_ref): Change proto.
(mu_message_unref): New proto (instead of macro).
* include/mailutils/mime.h (mu_mime_ref)
(mu_mime_unref, mu_mime_to_message): New protos.
* include/mailutils/sys/message.h (MESSAGE_MODIFIED)
(MESSAGE_INTERNAL_STREAM): New constants (from mime.c)
(MESSAGE_MIME_OWNER): New constant.
(_mu_message) <ref_count>: Rename from ref.
* include/mailutils/sys/mime.h (MIME_SEEK_ACTIVE): New constant.
(_mu_mime) <ref_count>: New member.
* libmailutils/mailbox/message.c (MESSAGE_MODIFIED)
(MESSAGE_INTERNAL_STREAM): Removed (see above).
* libmailutils/mailer/mailer.c (mu_message_unref): New function.
(mu_message_destroy): Rewrite.
(mu_message_ref): Returns void.
(mu_message_lines): Don't access header and body directly to
give virtual functions a chance to initialize them.
(mu_message_quick_lines): likewise.
* libmailutils/mailer/mailer.c (send_fragments): Use mu_mime_to_message
instead of mu_message_unref.
* libmailutils/mime/mime.c (_mime_append_part): Set offset only if
mime->stream is not null.
(_mime_body_stream_seek): Implement (albeit inefficiently).
(mu_mime_create): Set ref_count.
(mu_mime_ref, mu_mime_unref): New functions.
(mu_mime_destroy): Reimplement as a wrapper over _mu_mime_free.
(mu_mime_get_message): Increase refcount of the message being returned.
(mu_mime_to_message): New function.
* libmailutils/stream/message_stream.c (_message_open): Handle arbitrary
text as RFC822 without headers.

* libmu_sieve/actions.c: Unref the message returned by mu_mime_get_message.
* libmu_sieve/extensions/vacation.c: Likewise.
* mh/mhn.c: Likewise.

* libmailutils/stream/stream.c (mu_stream_seek) <MU_SEEK_CUR>: Bugfix.
      Sergey Poznyakoff authored
  31. 25 Aug, 2011 1 commit
  33. 04 Aug, 2011 1 commit
    • Various bugfixes. · eb851fbc 
      * libmailutils/base/assoc.c (first): Set index to max value
if tab is NULL to indicate immediate end of iteration.
* libmu_auth/sql.c (mu_auth_sql_by_name)
(mu_auth_sql_by_uid): Check the return from mu_sql_num_tuples.
(mu_sql_getpass): Check the number of returned tuples.
Return failure if returned a NULL password.
* libmu_scm/mu_message.c (string_sloppy_member): Remove.
(mu-message-get-header-fields): Use scm_member instead of
string_sloppy_member.
* sql/postgres.c (chop): Handle NULL argument.
      Sergey Poznyakoff authored
  35. 27 Jul, 2011 1 commit
  37. 19 Jul, 2011 1 commit
  39. 17 Jul, 2011 1 commit
    • Bugfixes. · b586670e 
      * libmailutils/base/rfc2047.c (mu_rfc2047_decode): Break if
reading from the filter fails.
* libmailutils/stream/fltstream.c (filter_read): Treat
mu_filter_moreinput in the lastbuf state as error.
      Sergey Poznyakoff authored
  41. 14 Jul, 2011 2 commits
    • Version 2.99.92 · 62b637f2 
      * NEWS: Update.
* configure.ac: Update.
* po/POTFILES.in: Update.
      Sergey Poznyakoff authored
    • Implement optional mailbox-independent locking for pop3d and imap4d. · d0769b4f 
      * lib/manlock.c: New file.
* lib/Makefile.am (libmuaux_a_SOURCES): Add manlock.c.
* lib/muaux.h (manlock_mandatory_locking)
(manlock_lock_dir): New externs.
(manlock_open_mailbox, manlock_lock)
(manlock_touchlock, manlock_unlock): New protos.

* libmailutils/base/amd.c (amd_cleanup): Remove unbalanced
call to mu_locker_unlock.
* libmailutils/base/locker.c (mu_locker_create): Bugfixes.

* imap4d/imap4d.c (imap4d_cfg_param): Add mandatory-locking
construct.
(main): Call manlock_cfg_init.
* imap4d/select.c (imap4d_select0): Use mandatory locking if
the mailbox is to be opened r/w.

* imap4d/rename.c (imap4d_rename): Note FIXME!

* imap4d/bye.c: Call manlock_unlock after closing the mailbox.
* imap4d/close.c: Likewise.
* imap4d/sync.c (imap4d_sync): Call manlock_touchlock.

* pop3d/lock.c: Remove.
* pop3d/Makefile.am (pop3d_SOURCES): Remove lock.c
* pop3d/extra.c (pop3d_abquit): Unlock mailbox.
* pop3d/pop3d.c (pop3d_cfg_param): Add mandatory-locking
construct.
(main): Call manlock_cfg_init.
(pop3d_mainloop): Call manlock_touchlock.
* pop3d/pop3d.h (pop3d_lock)
(pop3d_touchlock, pop3d_unlock): Remove.
* pop3d/quit.c (pop3d_quit): Unlock the mailbox.
* pop3d/user.c (pop3d_begin_session): Use manlock_open_mailbox.
      Sergey Poznyakoff authored
  43. 07 Jul, 2011 1 commit
    • Bugfix. · a9667edc 
      * libmailutils/string/vasnprintf.c (mu_vasnprintf): Operate on
a fresh copy of va_alist in each new iteration.
* libproto/imap/folder.c: Likewise.
* libproto/nntp/nntp_sendline.c: Likewise.
      Sergey Poznyakoff authored
  45. 04 Jul, 2011 3 commits
    • Allow caller to set up custom in,out,err,progname,tag before calling mu_app_init. · 5e1d982e 
      * include/mailutils/stdstream.h (MU_STDSTREAM_RESET_STRIN)
(MU_STDSTREAM_RESET_STROUT,MU_STDSTREAM_RESET_STRERR)
(MU_STDSTREAM_RESET_NONE,MU_STDSTREAM_RESET_ALL): New flags.
(mu_stdstream_setup): Change signature. All uses updated.
* libmailutils/stdstream/basestr.c (mu_stdstream_setup):
Use the flags argument to decide whether to close existing
streams.
Make sure stdstream_flushall enters the onexit queue only once.
* libmu_argp/muinit.c (mu_app_init): Don't override variables
that may be set by the caller (program_name, tag, streams).
      Sergey Poznyakoff authored
    • Fixes. · 1b5098c9 
      * libmailutils/diag/errors: Fix typo.
* libproto/imap/connect.c: Add missing includes.
* mh/tests/mhn.at: Add extra argument quoting.
      Sergey Poznyakoff authored
    • Minor fix. · d09b1d73 
      * libmailutils/diag/wd.c (mu_wd): Revamp the loop to ensure the proposed
way of connecting with gdb works in case of a non-zero timeout.
      Sergey Poznyakoff authored
  47. 20 Jun, 2011 1 commit
  49. 08 Jun, 2011 1 commit
    • Various minor fixes. · 79cbad0d 
      * include/mailutils/diag.h (mu_full_program_name): New extern.
* libmailutils/diag/diag.c (mu_full_program_name): New global.
(mu_set_program_name): Set mu_full_program_name.
(mu_diag_at_locus): Fix format specifier.
* libmailutils/diag/bt.c: Use mu_full_program_name instead of
program_invocation_name.
* libmailutils/diag/wd.c (mu_wd): Likewise.

* comsat/comsat.c: Fix format specifiers.
* lib/mailcap.c: Likewise.
* libmu_sieve/util.c: Cast formatted arguments to match format specs.
* mh/mh_getopt.c: Likewise.

* libmailutils/cidr/fromstr.c: Add missing includes.
* libproto/mailer/smtp.c: Likewise.
* libproto/pop/mbox.c: Likewise.
* testsuite/smtpsend.c: Likewise.
* mu/getarg.c: Likewise.
* mu/imap.c: Likewise.
* mu/pop.c (com_connect): Protect TLS code with #ifdef.
* mu/Makefile.am (EXTRA_DIST): Add mu-setup.awk.

* mail/summary.c (mail_summary): Fix data types of the counters.
      Sergey Poznyakoff authored
  51. 16 May, 2011 1 commit
    • Bugfixes. · 73be707d 
      * libmailutils/cfg/parser.y (STRTONUM, STRxTONUM)
(GETSNUM, GETUNUM): Remove unused arguments.
* libmailutils/stream/tcp.c (mu_tcp_stream_create_from_sa): Take
care not to destroy sockaddr arguments in case of failure.
      Sergey Poznyakoff authored