John McEleney / mailutils

the display.

Alain Magloire authored 2001-01-26 04:50:35 +0000

failed ofile == NULL we should not attempt to fprintf(ofile, ..) nor
fflush().  Buglet discover when working on imap4d.
pop3d.[ch]/user.c : indentation and comments.

Alain Magloire authored 2001-01-25 05:12:42 +0000

Alain Magloire authored 2001-01-25 05:09:03 +0000

change, this will help to know if the message_is_modified() and speed things
up when expunging.
file_stream.c : Don't disable the stream buffering and let the OS choose the
best BUFSIZ i.e. remove setbuf() call.
message.c registrar.c mailer.c folder.c header.c list.c mailbox.c :
Copyright and indent.
mapfile_stream.c mbx_imap.c mbx_mbox.c mbx_pop.c : go easy on the stack
for array of strings.
stream.c : Put code for doing our own simple littel buffering.

Alain Magloire authored 2001-01-25 05:08:41 +0000

was doing the equivalent of:

char buffer[1024];
memset (buffer, 0, 1024);
...
read (popfd, buffer, 1024);
...
ret = malloc (strlen (buffer) +1);

According to the rfc a command line should be no longer then
255 but a malicious client could send a big buffer that could fit
1024 then buffer would not be null terminated, strlen(buffer) may
be supceptible to overflow.  A simple fix would be to
read (fd, buffer, 1023); /* leave space for a null */
I've put a different fix that does not need the call to memset().
And at the same time reduce the size of the buffer to  go
easy on the stack 512 is sufficient.

Alain Magloire authored 2001-01-23 17:13:22 +0000

Jakob Kaivo authored 2001-01-23 10:33:59 +0000

Jakob Kaivo authored 2001-01-23 10:26:09 +0000

Jeff Bailey authored 2001-01-20 04:52:47 +0000

pop: RETR and TOP if buffer is not a full line i.e terminated by a '\n' realloc
the buffer and try again.
pop: STAT remove excess comment.
pop: user use the /dev/null scheme if mailbox does not exist.
mailbox: buglet if the mailbox format we were reading less then expected.

Alain Magloire authored 2001-01-20 04:34:39 +0000

Alain Magloire authored 2001-01-19 05:05:59 +0000

to the "frm" that comes with elm package.  It was written in less then 15
minutes, cool.

Alain Magloire authored 2001-01-19 05:03:13 +0000

Alain Magloire authored 2001-01-17 03:43:06 +0000

Alain Magloire authored 2001-01-17 00:48:18 +0000

Alain Magloire authored 2001-01-16 06:24:53 +0000

include multiple times.  Compiler like Watcomm C, will scream loudly
about definition of those variables multiple times.  Gcc is very silent
about this.  So in pop3d.h we declare those variables extern and move the
definition in pop3d.c.
MAXHOSTNAMELEN is define in netinet/in.h on Solaris so we guard with
#ifdef's.
We were calling syslog("%s ", NULL); On solaris passing a NULL to  a printf
function will crash and  burn, this was a FIXME I did not see it earlier
the NULL was the place holder for the mailbox name.

Alain Magloire authored 2001-01-16 06:24:08 +0000

address.c mime.c misc.c: Always cast to (unsigned char) when using the ctype
functions like isspace();
mbx_default.c: If _PATH_SENDMAIL not set via paths.h use "/usr/spool/mail"
message.c: uidl is now <md5 . time . sequene>
tcp.c: INADDR_NONE is not define on solaris define it to -1.

Alain Magloire authored 2001-01-16 06:14:52 +0000

Modify send.c to sendmail an create temporary filenames more securely.
Copyright change --> 2001 and extra spaces nukes, done by emacs automaticaly.

Alain Magloire authored 2001-01-16 06:10:41 +0000

mail: fix list.c so that command listing is formatted properly
pop3: STAT command didn't properly reflect deleted messages

Jakob Kaivo authored 2001-01-16 04:03:33 +0000

Alain Magloire authored 2001-01-15 15:45:01 +0000

(struct sockaddr *)

Alain Magloire authored 2001-01-15 15:32:18 +0000

Alain Magloire authored 2001-01-15 14:48:44 +0000

Alain Magloire authored 2001-01-15 04:19:43 +0000

Remove much of the code from body to use file_stream.c

Alain Magloire authored 2001-01-15 03:58:10 +0000

Alain Magloire authored 2001-01-14 21:59:44 +0000

Alain Magloire authored 2001-01-14 21:58:46 +0000

When expunging check if the message as been modified, for example
"X-UIDL" maybe add in the header it will now be save in the message.
expunge reuse the same code of mbox_append_message().
add a new header_set_fill() to get the header of the messages form the mailbox.

Alain Magloire authored 2001-01-14 21:58:08 +0000

Alain Magloire authored 2001-01-14 21:55:38 +0000

doing the right thing

Jakob Kaivo authored 2001-01-13 08:23:51 +0000

first pass at implementing file/folder command - you can now switch folders on the fly
tracked down bug in argcv.c that made mail shell/! function not work properly
removed unnecessary #if stuff from source.c

Jakob Kaivo authored 2001-01-13 07:18:57 +0000

Alain Magloire authored 2001-01-11 20:00:48 +0000

crashes.  Couple of places check if (ptr == NULL) before free(), this is
not a bug since POSIX requires free(NULL) to be legal but on some old station
like SunOS-4 that will corrupt the freelist or crash.
Some Copyright updates.

Alain Magloire authored 2001-01-11 06:43:55 +0000

Alain Magloire authored 2001-01-11 05:29:59 +0000

Alain Magloire authored 2001-01-11 05:29:23 +0000

setuid() call for apop.

Alain Magloire authored 2001-01-11 04:46:34 +0000

Beginning of mail source command implementation
Have mail source MAILRC file on startup
Fix bugs in mail pipe command

Jakob Kaivo authored 2001-01-11 00:01:09 +0000

no arm but may run out of file descriptors.

Alain Magloire authored 2001-01-10 20:18:20 +0000

Alain Magloire authored 2001-01-10 17:56:54 +0000

Alain Magloire authored 2001-01-10 14:51:26 +0000

Alain Magloire authored 2001-01-10 05:05:36 +0000

Alain Magloire authored 2001-01-10 05:04:10 +0000