1. 20 Sep, 2010 4 commits
    • * libproto/mailer/smtp.c: Rewrite using new SMTP API.
      * libproto/mailer/smtp_quit.c (mu_smtp_quit): Return immediately
      if already in closed state.
      
      * libmailutils/ticket.c (mu_ticket_get_cred): Return MU_ERR_FAILURE
      if all methods fail.
      * mail/send.c: Port 23321cf7 from patches-2.2
      (msg_to_pipe): Return status code.
      (save_dead_message, send_message): New functions, extracted from
      mail_send0.
      (mail_send0): Call save_dead_message if sending failed.
      Sergey Poznyakoff authored
    • * include/mailutils/smtp.h (mu_smtp_write): Mark as printf-like.
      (mu_smtp_mail_basic, mu_smtp_rcpt_basic): Take variable number
      of arguments.  Mark as printf-like.
      (mu_smtp_data): New prototype.
      * include/mailutils/sys/smtp.h (_MU_SMTP_SAVEBUF): New flag.
      (_mu_smtp) <savebuf>: New member.
      (_mu_smtp_data_begin, _mu_smtp_data_end): New protos.
      * libproto/mailer/smtp_send.c: New file.
      * libproto/mailer/smtp_data.c (_mu_smtp_data_begin)
      (_mu_smtp_data_end, mu_smtp_data): New functions.
      
      * libproto/mailer/Makefile.am (libmu_mailer_la_SOURCES): Add smtp_send.c.
      * libproto/mailer/smtp_ehlo.c (mu_smtp_ehlo): Switch to MU_SMTP_EHLO
      only if in MU_SMTP_MAIL state.
      * libproto/mailer/smtp_mail.c (mu_smtp_mail_basic): Take variable number
      of arguments.
      * libproto/mailer/smtp_param.c (mu_smtp_get_param): Add missing typecast.
      * libproto/mailer/smtp_rcpt.c (mu_smtp_rcpt_basic): Take variable number
      of arguments.
      * libproto/mailer/smtp_send.c (_smtp_data_send): Use _mu_smtp_data_begin and
      _mu_smtp_data_end.
      * testsuite/smtpsend.c: Emulate sending from a MU message.
      Sergey Poznyakoff authored
    • * include/mailutils/stream.h (mu_stream_printf): Mark as printf-like.
      * include/mailutils/sys/stream.h (_MU_STR_EVENT_CLOSE): New event.
      (_mu_stream) <event_cb_data>: New member.
      * libmailutils/stream.c (mu_stream_seek): Avoid unnecessary seeks
      in mu_buffer_none mode.  Complements 906499db.
      (mu_stream_close): Mark _MU_STR_EVENT_CLOSE event.
      Sergey Poznyakoff authored
    • * libmailutils/message_stream.c (scan_stream): Change signature.  All
      uses updated.
      Correct the calculation of body_start.
      (mu_message_stream_create): Return the stream.
      Sergey Poznyakoff authored
  2. 19 Sep, 2010 5 commits
  3. 18 Sep, 2010 1 commit
    • * configure.ac (MU_COND_GSASL): New cond.
      * include/mailutils/smtp.h (MU_SMTP_PARAM_DOMAIN)
      (MU_SMTP_PARAM_USERNAME, MU_SMTP_PARAM_PASSWORD)
      (MU_SMTP_PARAM_SERVICE, MU_SMTP_PARAM_REALM)
      (MU_SMTP_PARAM_HOST, MU_SMTP_MAX_PARAM): New constants.
      (mu_smtp_set_domain, mu_smtp_get_param): Remove.
      (mu_smtp_set_param, mu_smtp_get_param): New prototypes.
      (mu_smtp_auth, mu_smtp_add_auth_mech)
      (mu_smtp_add_auth_mech_list, mu_smtp_mech_select): New prototypes.
      * include/mailutils/sys/smtp.h (_mu_smtp) <domain>: Remove.
      (_mu_smtp) <authimpl, param, authmech>: New members.
      (_mu_smtp_gsasl_auth, _mu_smtp_mech_impl): New prototypes.
      
      * libproto/mailer/Makefile.am [MU_COND_GSASL]: Define SMTP_GSASL.
      (libmu_mailer_la_SOURCES): Add new sources.
      * libproto/mailer/smtp_domain.c: Remove.
      * libproto/mailer/smtp_param.c: New file.
      * libproto/mailer/smtp_mech.c: New file.
      * libproto/mailer/smtp_auth.c: New file.
      * libproto/mailer/smtp_gsasl.c: New file.
      * libproto/mailer/smtp_create.c (mu_smtp_destroy): Free new members of
      struct _mu_smtp.
      * libproto/mailer/smtp_ehlo.c (mu_smtp_ehlo): Use param[MU_SMTP_PARAM_DOMAIN]
      instead of domain.
      * testsuite/smtpsend.c: Handle SMTP AUTH.
      
      * libmu_auth/gsasl.c (mu_gsasl_stream_create): Bugfix.
      
      * libmailutils/xscript-stream.c (_xscript_ctl)
      <MU_IOCTL_SWAP_STREAM>: If instream!=outstream, combine them first
      into an iostream.
      Sergey Poznyakoff authored
  4. 17 Sep, 2010 5 commits
    • * include/mailutils/smtp.h (mu_smtp_mail_basic)
      (mu_smtp_rcpt_basic, mu_smtp_send_stream)
      (mu_smtp_rset, mu_smtp_quit): New prototypes.
      * include/mailutils/sys/smtp.h (MU_SMTP_RCPT)
      (MU_SMTP_MORE, MU_SMTP_DOT, MU_SMTP_QUIT, MU_SMTP_CLOS): New states.
      (_mu_smtp_xscript_level): New proto.
      * libmailutils/errors (MU_ERR_REPLY): New error code.
      * libproto/mailer/Makefile.am (libmu_mailer_la_SOURCES): Add new sources.
      * libproto/mailer/smtp_data.c: New file.
      * libproto/mailer/smtp_mail.c: New file.
      * libproto/mailer/smtp_quit.c: New file.
      * libproto/mailer/smtp_rcpt.c: New file.
      * libproto/mailer/smtp_rset.c: New file.
      * libproto/mailer/smtp_ehlo.c: Return MU_ERR_REPLY if the server replied
      with a code other than 2xx.
      * libproto/mailer/smtp_open.c: Likewise.
      * testsuite/smtpsend.c: Implement full sending cycle (excepting
      authorization).
      Sergey Poznyakoff authored
    • * sieve/tests/reject.at: Fix dependency on TZ.
      * sieve/tests/relational.at: Ensure that fileintos go
      to the test folder.
      * sieve/tests/mul-addr.at: Remove unneeded require.
      Sergey Poznyakoff authored
    • * include/mailutils/smtp.h: New file.
      * include/mailutils/Makefile.am (pkginclude_HEADERS): Add smtp.h.
      * include/mailutils/list.h (mu_list_clear): New proto.
      * include/mailutils/sys/smtp.h: New file.
      * include/mailutils/sys/Makefile.am (sysinclude_HEADERS): Add smtp.h.
      * libmailutils/errors (MU_ERR_BADREPLY, MU_ERR_SEQ): New error codes.
      * libmailutils/list.c (mu_list_clear): New function.
      * libproto/mailer/Makefile.am (libmu_mailer_la_SOURCES): Add new sources.
      * libproto/mailer/smtp_capa.c: New file.
      * libproto/mailer/smtp_carrier.c: New file.
      * libproto/mailer/smtp_create.c: New file.
      * libproto/mailer/smtp_disconnect.c: New file.
      * libproto/mailer/smtp_domain.c: New file.
      * libproto/mailer/smtp_ehlo.c: New file.
      * libproto/mailer/smtp_io.c: New file.
      * libproto/mailer/smtp_open.c: New file.
      * libproto/mailer/smtp_starttls.c: New file.
      * libproto/mailer/smtp_trace.c: New file.
      * testsuite/smtpsend.c: New file.
      * testsuite/Makefile.am (noinst_PROGRAMS): Add smtpsend.
      Sergey Poznyakoff authored
    • * bootstrap.conf: Build included listings in doc/texinfo.
      * configure.ac: Require gettext 0.18
      * doc/texinfo/Makefile.am: Remove the .c.inc rules.
      * doc/texinfo/maint.mk: New file.
      * lib/Makefile.am (libmuaux_la_SOURCES): Replace with libmuaux_a_SOURCES.
      Sergey Poznyakoff authored
    • Git does not keep empty subdirectories, so we need to recreate /cur and
      /tmp subdirs in maildir mailboxes retrieved from the repo.
      
      * bootstrap.conf: Recreate missing maildir parts.
      * testsuite/testsuite.inc (MUT_MBCOPY): New macro.
      * sieve/tests/ext.at: Use MUT_MBCOPY to copy mailboxes.
      * sieve/tests/redirect.at: Likewise.
      * sieve/tests/reject.at: Likewise.
      * sieve/tests/testsuite.at: Likewise.
      * testsuite/mbdel.at: Likewise.
      * frm/tests/Makefile.am: Testsuite depends on
      $(top_srcdir)/testsuite/testsuite.inc.
      * libmailutils/tests/Makefile.am: Likewise.
      * messages/tests/Makefile.am: Likewise.
      * readmsg/tests/Makefile.am: Likewise.
      * sieve/tests/Makefile.am: Likewise.
      * testsuite/Makefile.am: Likewise.
      Sergey Poznyakoff authored
  5. 16 Sep, 2010 2 commits
    • That's the first commit since the merge six days ago that passes
      distcheck (with python, cxx, imap and nntp disabled, of course).
      
      * testsuite/folder/DISTFILES: Restore. It is needed for some
      of the remaining DejaGNU tests.
      * testsuite/spool/DISTFILES: Likewise.
      * testsuite/testsuite.at: New file.
      * testsuite/atlocal.in: New file.
      * libmailutils/tests/mbdel.at: Move to testsuite/.
      * libmailutils/tests/mbdel.c: Likewise.
      * libmailutils/tests/mime.at: Likewise.
      * libmailutils/tests/mimetest.c: Likewise.
      
      * Makefile.am (SUBDIRS): Place testsuite after libproto.
      * configure.ac (AM_INIT_AUTOMAKE): Remove dist-lzma.
      (AC_CONFIG_FILES): Add testsuite/atlocal.
      * libmailutils/base64.c (_base64_decoder)
      (_base64_encoder): Fix the use of uninitialized variables.
      * libmailutils/tests/.gitignore: Remove mbdel and mimetest.
      * libmailutils/tests/Makefile.am (noinst_PROGRAMS): Remove mbdel and mimetest.
      (LDADD): Leave only MU_LIB_MAILUTILS.
      (TESTSUITE_AT): Remove mbdel.at and mime.at
      * libmailutils/tests/atlocal.in (PATH): Bugfix.
      * libmailutils/tests/testsuite.at: Remove inclusion of mbdel.at and mime.at.
      * po/POTFILES.in: Replace mailbox/ with libmailutils/.
      
      * testsuite/.gitignore: Rewrite.
      * testsuite/Makefile.am: Rewrite.
      * testsuite/mbdel.at: Set +w on all copied mailboxes.
      * testsuite/mimetest.c (main): Open mailbox for reading only.
      
      * sieve/Makefile.am: Add examples/ to the distribution.
      
      * libproto/mbox/mbox.c (mbox_open): Create locker only
      if the mailbox is open for modification.
      All users updated to check for mailbox->locker!=NULL before
      using it.
      Sergey Poznyakoff authored
    • * libmailutils/tests/mbdel.at: New testcase.
      * libmailutils/tests/Makefile.am (TESTSUITE_AT): Add mbdel.at.
      * libmailutils/tests/testsuite.at: Include mbdel.at.
      * libproto/mbox/mbox.c (mbox_remove): Fix return code.
      
      * testsuite/maildir/mbox1: New test mailbox.
      * testsuite/mh/mbox1: New test mailbox.
      * testsuite/etc/DISTFILES: Remove.
      * testsuite/folder/DISTFILES: Remove.
      * testsuite/lib/DISTFILES: Remove.
      * testsuite/Makefile.am: Use EXTRA_DIST to distribute
      subdirs.
      Sergey Poznyakoff authored
  6. 15 Sep, 2010 4 commits
    • Minor fix. · d74b5f53
      * libmailutils/mailbox.c (mu_mailbox_open): Return MU_ERR_OPEN
      if the mailbox has already been opened.
      Sergey Poznyakoff authored
    • * include/mailutils/mailbox.h (mu_mailbox_remove): New function.
      * include/mailutils/stream.h: Add some comments.
      * include/mailutils/sys/amd.h (_amd_data)<remove>: New method.
      (amd_remove_dir): New function.
      * include/mailutils/sys/mailbox.h (_mu_mailbox)<_remove>: New
      method.
      * libmailutils/amd.c (amd_remove_mbox): New function.
      (amd_init_mailbox): Initialize the _remove method.
      (amd_remove_dir): New function.
      * libmailutils/errors (MU_ERR_MBX_REMOVED)
      (MU_ERR_NOT_OPEN, MU_ERR_OPEN): New error codes.
      * libmailutils/mailbox.c: Keep state of the mailbox (open vs. not
      open, removed). Check it before doing anything on it.
      (_MU_MAILBOX_OPEN, _MU_MAILBOX_REMOVED, _MU_MAILBOX_MASK): New
      defines.
      (mu_mailbox_open): Set _MU_MAILBOX_OPEN if the operation succeeds.
      (mu_mailbox_close): Clear _MU_MAILBOX_OPEN if the operation succeeds.
      Refuse to run if the mailbox was not opened.
      (mu_mailbox_remove): New function.
      (all functions): return MU_ERR_MBX_NULL if the mbox argument is
      NULL.
      Check mailbox state on entry and proceed accordingly.
      * libproto/maildir/mbox.c: Implement _remove method.
      (maildir_remove): New function.
      (_mailbox_maildir_init): Initialize amd->_remove.
      * libproto/mbox/mbox.c: Implement _remove method.
      (mbox_remove): New function.
      (_mailbox_mbox_init): Initialize amd->_remove.
      * libproto/mh/mbox.c: Implement _remove method.
      (mh_remove): New function.
      (_mailbox_mh_init): Initialize amd->_remove.
      
      * libmailutils/tests/mbdel.c: New file.
      * libmailutils/tests/.gitignore: Add mbdel.
      * libmailutils/tests/Makefile.am (noinst_PROGRAMS): Likewise.
      (LDADD): List all mailbox formats.
      
      * imap4d/delete.c (imap4d_delete): Use mu_mailbox_remove to
      delete the folder.  Fall back to remove() if it does not appear
      to be a mailbox.
      Sergey Poznyakoff authored
    • * examples/listop.c: Move to libmailutils/tests.
      * examples/Makefile.am (noinst_PROGRAMS): Remove listop.
      * libmailutils/tests/Makefile.am (noinst_PROGRAMS): Add listop.
      (TESTSUITE_AT): Add list.at.
      * libmailutils/tests/.gitignore: New file.
      * libmailutils/tests/list.at: New file.
      * libmailutils/tests/testsuite.at: Include list.at.
      
      * libmailutils/list.c (list_itrctl): Fix mu_itrctl_replace.
      Sergey Poznyakoff authored
    • * libmailutils/tests/testsuite.at (MU_TEST_GROUP)
      (MU_TEST_KEYWORDS, MU_TEST_COMMAND): New defines.
      (mu_trimstr, mu_firstline): New macros.
      (MU_GENERIC_TEST): New macro.
      * libmailutils/tests/addr.c: Accept addresses from stdin.
      * libmailutils/tests/address.at (TESTADDR): If the address
      contains single quotes, pass it to the program via stdin.
      Uncomment all such tests.
      * libmailutils/tests/argcv.at (TESTARGS): Rewrite as a wrapper
      over MU_GENERIC_TEST.
      * libmailutils/tests/decode2047.at (TESTDEC2047): Likewise.
      * libmailutils/tests/mailcap.at (MAILCAP): Likewise.
      * libmailutils/tests/url.at (TESTURL): Likewise.
      * libmailutils/tests/mailcap.c: Accept data from stdin.
      Sergey Poznyakoff authored
  7. 14 Sep, 2010 6 commits
    • * libmailutils/Makefile.am (SUBDIRS): Make sure tests are descended
      into only when the libmailutils library is already built.
      Sergey Poznyakoff authored
    • * configure.ac: Remove messages/testsuite
      * messages/Makefile.am (SUBDIRS): Replace testsuite with tests.
      * messages/tests/.gitignore: New file.
      * messages/tests/Makefile.am: New file.
      * messages/tests/atlocal.in: New file.
      * messages/tests/testsuite.at: New file.
      * messages/testsuite: Remove.
      Sergey Poznyakoff authored
    • * configure.ac: Create libmailutils/tests/atlocal and
      libmailutils/tests/Makefile. Remove libmailutils/testsuite.
      * examples/Makefile.am (noinst_PROGRAMS): Remove programs moved
      to libmailutils/tests.
      * examples/argcv.c -> libmailutils/tests/argcv.c
      * libmailutils/testsuite/Decode -> libmailutils/tests/Decode
      * libmailutils/testsuite/Encode -> libmailutils/tests/Encode
      * examples/decode2047.c: Move to libmailutils/tests
      * examples/encode2047.c: Move to libmailutils/tests
      * examples/mailcap.c: Likewise.
      * examples/url-parse.c: Likewise.
      
      * include/mailutils/Makefile.am: Minor changes.
      * libmailutils/Makefile.am (SUBDIRS): Replace testsuite with tests.
      * libmailutils/tests/Makefile.am: New file.
      * libmailutils/tests/addr.c: New file.
      * libmailutils/tests/address.at: New file.
      * libmailutils/tests/argcv.at: New file.
      * libmailutils/tests/atlocal.in: New file.
      * libmailutils/tests/base64d.at: New file.
      * libmailutils/tests/base64e.at: New file.
      * libmailutils/tests/decode2047.at: New file.
      * libmailutils/tests/encode2047.at: New file.
      * libmailutils/tests/fltst.c: New file.
      * libmailutils/tests/mailcap.at: New file.
      * libmailutils/tests/mime.at: New file.
      * libmailutils/tests/testsuite.at: New file.
      * libmailutils/tests/url.at: New file.
      
      * libmailutils/testsuite/: Delete.
      
      * frm/tests/Makefile.am: Prefix package.m4 creation commands with $(AM_V_GEN).
      * readmsg/tests/Makefile.am: Likewise.
      * sieve/tests/Makefile.am: Likewise.
      * frm/tests/testsuite.at: Minor changes.
      * readmsg/tests/testsuite.at: Include testsuite.inc.
      * sieve/tests/testsuite.at: Likewise.
      * sieve/tests/version.at: Comment out inclusion of testsuite.inc.
      * testsuite/testsuite.inc: Add m4_version_prereq.
      Sergey Poznyakoff authored
    • This change has been waiting since 2005-08-16 (aaab8814),
      when libmailbox had been renamed to libmailutils.  Back then MU
      was still under CVS, which didn't like renames.
      Sergey Poznyakoff authored
    • * configure.ac: Add readmsg/tests/
      * readmsg/Makefile.am: New file.
      * readmsg/tests/.gitignore: New file.
      * readmsg/tests/Makefile.am: New file.
      * readmsg/tests/all.at: New file.
      * readmsg/tests/atlocal.in: New file.
      * readmsg/tests/hdr.at: New file.
      * readmsg/tests/nohdr.at: New file.
      * readmsg/tests/testsuite.at: New file.
      * readmsg/tests/twomsg.at: New file.
      * readmsg/tests/weed.at: New file.
      * readmsg/testsuite: Remove.
      * testsuite/testsuite.inc (AT_SKIP_TEST): New macro.
      
      * testsuite/spool/mbox1: Remove trailing whitespace after Received headers.
      * imap4d/testsuite/imap4d/fetch.exp: Reflece changes in mbox1.
      * mail/testsuite/mail/read.exp: Likewise.
      * mail/testsuite/mail/write.exp: Likewise.
      * mailbox/testsuite/Mime: Likewise.
      Sergey Poznyakoff authored
    • * configure.ac: Build frm/testsuite/Makefile.am and atlocal.
      Remove frm/testsuite/Makefile.
      * testsuite/testsuite.inc: New file.
      
      * frm/testsuite: Remove DejaGNU-based testsuite.
      * frm/tests: Autotest-based testsuite.
      * frm/tests/.gitignore
      * frm/tests/Makefile.am
      * frm/tests/atlocal.in
      * frm/tests/testsuite.at
      
      * frm/Makefile.am (SUBDIRS): Replace testsuite with tests.
      
      * sieve/tests/Makefile.am (TESTSUITE): Add an include option.
      * sieve/tests/version.at: Use macro from testsuite.inc.
      Sergey Poznyakoff authored
  8. 13 Sep, 2010 3 commits
    • * sieve/examples/INBOX.orig
      * sieve/examples/Test
      * sieve/examples/test.out
      Sergey Poznyakoff authored
    • * mailbox/cfg_parser.y (mu_cfg_create_subtree): Optional prefix
      character may be used to alter the separator or to suppress
      value splitting.
      Sergey Poznyakoff authored
    • * include/mailutils/sys/stream.h (_MU_STR_EVENT_SET): Rename
      to _MU_STR_EVENT_SET.
      (_MU_STR_EVENT_CLR): Rename to _MU_STR_EVENT_CLRFLAG.
      (_MU_STR_EVENT_FILLBUF, _MU_STR_EVENT_FLUSHBUF): New event codes.
      (_MU_STR_EVMASK): New macro.
      (_mu_stream) <cur>: Replace with pos, indicating current position
      in the buffer.
      (event_cb): Change signature.
      (mu_stream_read_unbuffered): Remove.
      (mu_stream_write_unbuffered): Remove.
      
      * mailbox/iostream.c (mu_iostream_create): Provide the readdelim method
      only if the underlying input transpor stream provides it.
      * mailbox/streamref.c (mu_streamref_create_abridged): Likewise.
      
      * mailbox/stream.c (_stream_event): New macro.
      (mu_stream_read_unbuffered): Rename to static _stream_read_unbuffered.
      (mu_stream_write_unbuffered): Rename to static _stream_write_unbuffered.
      (_stream_advance_buffer, _stream_buffer_offset)
      (_stream_orig_level): Remove macros.
      (_stream_buffer_freespace): Rewrite.
      (_stream_curp): New macro.
      (_stream_fill_buffer): Make sure the `offset' indicates the offset
      int the transport, corresponding to the beginning of the current
      buffer.
      (_stream_flush_buffer): Essentially rewritten.
      (mu_stream_seek): Reflect changes to the _mu_stream structure. Optimize
      calls to the seek method.
      (_stream_skip_input_bytes): Likewise.
      (mu_stream_read, _stream_scandelim, mu_stream_write): Rewrite using
      new _mu_stream structure.
      
      * mailbox/xscript-stream.c: Rewrite using stream events.
      
      * mailbox/base64.c (_base64_encoder): Bugfix.
      
      * libproto/pop/pop3_stream.c (_pop3_event_cb): Update signature to
      match the changes above.
      * examples/mimetest.c (main): Add more error checking.
      * mail/testsuite/mail/write.exp: Minor fix.
      Sergey Poznyakoff authored
  9. 12 Sep, 2010 3 commits
    • * imap4d/quota.c: New file.
      * imap4d/Makefile.am (imap4d_SOURCES): Add quota.c
      * imap4d/append.c (imap4d_append0): Refuse to append if
      the quota is exceeded or would be exceeded after completing
      the operation.
      * imap4d/copy.c (imap4d_copy0): Refuse to copy messages if
      the quota is exceeded or would be exceeded after completing
      the operation.
      Return a meaningful textual description.
      Attempt to restore mailbox to its original size if the operation failed.
      * imap4d/imap4d.c (imap4d_session_setup0): Call quota_setup.
      * imap4d/imap4d.h (quota_setup, quota_check, quota_update): New functions.
      
      * include/mailutils/folder.h (mu_list_response) <format>: New member.
      * include/mailutils/mailbox.h (mu_mailbox_create_from_record): New
      function.
      * include/mailutils/types.hin (MU_FOLDER_ATTRIBUTE_LINK): New flag.
      * libproto/mbox/folder.c (list_helper): Do not return symbolic links
      unless MU_FOLDER_ATTRIBUTE_LINK is set.
      Fill in the resp->format member.
      * mailbox/mailbox.c (_mailbox_create_from_record): New static function.
      (_create_mailbox0): Rewrite as a wrapper over _mailbox_create_from_record.
      (mu_mailbox_create_from_record): New function.
      Sergey Poznyakoff authored
    • * movemail/movemail.c (guess_mbox_owner): Fix setting GID
      with --owner=set-id.
      (main): Don't attempt to expunge source mailbox if preserve_mail
      is set.
      Sergey Poznyakoff authored
    • * mailbox/amd.c (read_size_file): Fix return value.
      Sergey Poznyakoff authored
  10. 11 Sep, 2010 3 commits
    • * libproto/pop/pop3_stream.c (_pop3_event_cb)
      (mu_pop3_filter_create): Fix buffer size manipulation.
      * libmu_auth/tls.c: Protect gnutls debugging code with
      DEBUG_TLS.
      Sergey Poznyakoff authored
    • As a side note, previous versions of pop3d did not do
      byte-stuffing when sending RETR output.  This commit fixes
      it.
      
      * include/mailutils/filter.h (mu_dot_filter): New filter.
      * mailbox/dot.c: New file.
      * mailbox/Makefile.am (libmailutils_la_SOURCES): Add dot.c
      * mailbox/crlfdot.c (_crlfdot_encoder): Bugfix. Do not
      dereference iobuf until we know it is not NULL.
      * mailbox/filter.c (mu_filter_get_list): Register mu_dot_filter.
      * mailbox/fltstream.c (filter_wr_close, filter_rd_close): New
      close methods, depending on the filter stream mode.
      (mu_filter_stream_create): Set filter_rd_close for MU_STREAM_READ
      and filter_wr_close for MU_STREAM_WRITE streams.
      * mailbox/stream.c (mu_stream_readdelim): Update stream offset
      when using stream->readdelim.
      
      * pop3d/pop3d.h (pop3d_send_payload): New proto.
      * pop3d/retr.c (pop3d_send_payload): Change function to be
      optionally used in pop3d_top.  Use DOT filter on output.
      * pop3d/top.c (pop3d_top): Rewrite using pop3d_send_payload.
      
      * libproto/pop/pop3_retr.c (mu_pop3_retr): Default return
      code is EINPROGRESS.
      * libproto/pop/pop3_stream.c: Remove the filter stuff.
      Use CRLFDOT instead.
      
      * mailbox/amd.c (amd_body_stream_readdelim): Bugfix.  Increase
      offset by nread bytes.
      Sergey Poznyakoff authored
    • * include/mailutils/filter.h (mu_filter_command) <mu_filter_flush> New command.
      (mu_filter_result) <mu_filter_again>: New result code.
      (MU_FILTER_MAX_AGAIN): New constant.
      (mu_crlfdot_filter): New filter.
      * include/mailutils/sys/stream.h (_MU_STR_DIRTY, _MU_STR_WRT)
      (_MU_STR_ERR, _MU_STR_EOF, _MU_STR_INTERN_MASK): Avoid conflicts with
      MU_STREAM_ constants from mailutils/stream.h
      
      * mailbox/crlfdot.c: New source.
      * mailbox/Makefile.am (libmailutils_la_SOURCES): Add crlfdot.c.
      * mailbox/filter.c (mu_filter_get_list): Register mu_crlfdot_filter.
      * mailbox/fltstream.c (init_iobuf): Fix initialization of isize and
      input.
      (filter_read): Redo the loop, allowing xcode to request a new
      iteration by returning mu_filter_again.
      (filter_write_internal): Likewise.
      (filter_wr_flush): Call filter_write_internal with mu_filter_flush, reserving
      mu_filter_lastbuf for really last buffers.
      (filter_close): Call filter_write_internal with mu_filter_lastbuf.
      * mailbox/stream.c (mu_stream_skip_input_bytes): Clear MU_STREAM_SEEK bit
      before actually doing anything.
      
      * include/mailutils/sys/pop3.h [DMALLOC]: Remove unneeded cond.
      Sergey Poznyakoff authored
  11. 09 Sep, 2010 4 commits
    • Sergey Poznyakoff authored
    • New ioctls MU_IOCTL_GET_TRANSPORT_BUFFER and
      MU_IOCTL_SET_TRANSPORT_BUFFER return and modify bufferization
      mode in the lowest level transport stream.  Both server and
      client programs use this to switch to full buffering before
      sending large amounts of data. This has a particular impact
      on the output speed and CPU usage when TLS is in use.
      
      * include/mailutils/stream.h (MU_IOCTL_GET_TRANSPORT_BUFFER)
      (MU_IOCTL_SET_TRANSPORT_BUFFER): New ioctls.
      (MU_TRANSPORT_INPUT, MU_TRANSPORT_OUTPUT): New constants.
      (MU_TRANSPORT_VALID_TYPE): New macro.
      (mu_buffer_query): New struct.
      (mu_stream_get_buffer): New proto.
      
      * libmu_auth/tls.c (_tls_io_ioctl): Return ENOSYS
      if op is not supported.
      (_tls_ioctl): Support MU_IOCTL_[GS]ET_TRANSPORT_BUFFER.
      * mailbox/file_stream.c (fd_ioctl): Support MU_IOCTL_[GS]ET_TRANSPORT_BUFFER.
      Return ENOSYS if op is not supported.
      * mailbox/filter_iconv.c (_icvt_ioctl): Likewise.
      * mailbox/iostream.c (_iostream_ctl): Likewise.
      * mailbox/mapfile_stream.c (_mapfile_ioctl): Likewise.
      * mailbox/memory_stream.c (_memory_ioctl): Likewise.
      * mailbox/rdcache_stream.c (rdcache_ioctl): Likewise.
      * mailbox/xscript-stream.c (_xscript_ctl): Likewise.
      * mailbox/prog_stream.c (_prog_ioctl): Return ENOSYS if op is not
      supported.
      * mailbox/tcp.c (_tcp_ioctl): Likewise.
      
      * mailbox/stream.c (mu_stream_default_buffer_size): New global.
      (mu_stream_seek): Do not call seek method if the requested offset
      is the same as the current one.
      (mu_stream_set_buffer): Size==0 means use the default value.
      (mu_stream_get_buffer): New function.
      (mu_stream_truncate): Flush the buffer before truncating.
      
      * mailbox/mime.c (mime_reset_state): New function.
      (_mime_body_stream_seek): Rewrite using mime_reset_state.
      (_mime_body_stream_ioctl): Return ENOSYS if op is not
      supported.
      (create_mime_body_stream): Reset mime state (_mime_body_stream_seek
      may not be called due to the optimization in mu_stream_seek.
      
      * mailbox/header.c (header_parse): Exit correctly if the buffer is
      not terminated with a \n.
      
      * libproto/mbox/mbox.c (mbox_open): Enforce full buffering on the
      mailbox stream.
      * libproto/pop/mbox.c (pop_header_fill): Minor fix.
      * libproto/pop/pop3_stream.c (_POP3F_DONE)
      (_POP3F_CHBUF): New constants.
      (mu_pop3_stream)<done>: Remove. Replaced with flags.
      <oldbuf>: New member.
      (_pop3_event_cb): If _POP3F_CHBUF flag is set, restore
      the initial buffering mode on the transport stream.
      (mu_pop3_filter_create): Save away current buffering mode
      and enforce full buffering while transferring bulk data.
      
      * mail/from.c (hdr_from): Check return value from mu_message_get_header.
      * mail/mail.c (main): Allow for MAILRC having empty value.
      Always close the mailbox before exiting.
      
      * pop3d/pop3d.c (pop3d_cfg_param): New statement output-buffer-size.
      * pop3d/pop3d.h (pop3d_output_bufsize): New global.
      * pop3d/retr.c (pop3d_send_payload): New function.
      (pop3d_retr): Rewrite using pop3d_send_payload. Save away
      current buffering mode and enforce full buffering while
      transferring bulk data.
      * pop3d/top.c (pop3d_top_: Likewise.
      Sergey Poznyakoff authored
    • * mailbox/url.c (ACCESSOR(is_same,field)): Fix coredump if one
      of the accessors returned MU_ERR_NOENT.
      Sergey Poznyakoff authored