John McEleney / mailutils

* libmailutils/base/amd.c (_amd_message_delete): Remove.
(amd_array_expand): Fix element size.
(amd_array_shrink): Rewrite.
(amd_expunge): Shrink the array once, after everything has been
expunged.
Generate MU_EVT_MAILBOX_MESSAGE_EXPUNGE for each expunged message.

Sergey Poznyakoff authored 2010-12-29 13:22:02 +0200

* libmailutils/diag/debug.c (mu_debug_log, mu_debug_log_begin): Call
mu_diag_init.

Sergey Poznyakoff authored 2010-12-29 10:02:16 +0200

* libmailutils/url/create.c (_mu_url_create_internal): Fix
parsing of the '|' shortcuts.
* libmailutils/tests/url.at: Fix '|' test. Add 'prog://' test.

* movemail/movemail.c (set_program_id): Call mu_stdstream_strerr_setup
to flush changes.
* frm/common.c: Minor changes

Sergey Poznyakoff authored 2010-12-29 00:47:26 +0200

* frm/common.c (select_message, msg_index): Remove; use action data instead.
(action): Use action data to get the selection function and message index.
(frm_scan): Pass these data in action closure.

Sergey Poznyakoff authored 2010-12-28 18:03:34 +0200

* imap4d/imap4d.h (util_format_attribute_flags): New prototype.
* imap4d/sync.c: Rewrite using flag table to keep attribute flags,
mu_mailbox_translate to convert uids to message numbers and
MU_EVT_MAILBOX_MESSAGE_EXPUNGE event to report expunged messages.
* imap4d/util.c  (_imap4d_attrlist): Remove \Recent
(util_attribute_to_type): Handle \Recent separately.
(util_format_attribute_flags): New function.
(util_print_flags): Rewrite as an extra entry point to the above.

mailboxes: New event MU_EVT_MAILBOX_MESSAGE_EXPUNGE.

* include/mailutils/observer.h: Rearrange and partially rename
event constants (all uses updated):
MU_EVT_MESSAGE_APPEND   =>   MU_EVT_MAILBOX_MESSAGE_APPEND
MU_EVT_AUTHORITY_FAILED =>   MU_EVT_FOLDER_AUTHORITY_FAILED
(MU_EVT_MAILBOX_MESSAGE_EXPUNGE): New event.
* libproto/mbox/mbox.c: Generate MU_EVT_MAILBOX_MESSAGE_EXPUNGE.
* libproto/pop/mbox.c: Likewise.
* libmailutils/base/amd.c: Likewise.

Sergey Poznyakoff authored 2010-12-28 17:43:15 +0200

* include/mailutils/sys/amd.h (_amd_message_append, amd_sort): New protos.
* libmailutils/base/amd.c (amd_array_expand): Call memmove only if there is
actually something to move.
(_amd_message_append, amd_sort): New functions.
* libproto/maildir/mbox.c (maildir_scan_dir): Append new messages to the
end of the array, and sort it afterwards. This avoids unnecessary memory
moves, which improves performance considerably, especially on large
mailboxes.
* libproto/mh/mbox.c (mh_scan0): Likewise.

Sergey Poznyakoff authored 2010-12-28 14:37:37 +0200

* libmu_sieve/extensions/vacation.c (build_mime): Remove superfluous seek.
(test_and_update_prop): days==0 means "forever", i.e. send a replay to
each user only once.
(vacation_reply): If :file tag is given, treat the argument as the
name of a file containing the reply message.
(vacation_tags): Add "sender" and "file" tags.

* libmu_sieve/extensions/moderator.c: Always unref transport stream
after passing it to mu_stream_to_message.
* maidag/lmtp.c: Likewise.
* mh/mh_stream.c: Likewise.
* mh/prompter.c: Likewise.
* mh/burst.c (flush_stream): Remove extra unnref.
* sieve/sieve.c: Likewise.
* testsuite/smtpsend.c: Likewise.

Sergey Poznyakoff authored 2010-12-28 11:52:19 +0200

* libmu_sieve/extensions/vacation.c: Use _sget accessors where possible.
Use mu_property_t instead of db database.
* libmu_sieve/sieve.y (mu_sieve_get_mailer): Verbosely report
errors.
* libmailutils/base/locker.c (mu_locker_create): Create the
locker if the file name part of its full name does not exist.

Sergey Poznyakoff authored 2010-12-27 13:28:31 +0200

* libmu_auth/tls.c (_tls_ioctl): Fix typo (opcode used instead of
code).
* mu/filter.c (mutool_filter): Reference mu_strin to prevent it from
destroying.
* testsuite/smtpsend.c (main): Call mu_stdstream_setup.

Sergey Poznyakoff authored 2010-12-26 00:22:01 +0200

* libproto/pop/mbox.c (pop_close): Destroy the cached data.
(pop_destroy): Avoid freeing the same data twice.
(pop_body_get_stream,pop_body_size,pop_body_lines): Owner is mu_message_t.
(pop_create_body): Change the owner of the created mu_body_t object.

* movemail/movemail.c: Correctly close both mailboxes if unhandled errors
occur.

Sergey Poznyakoff authored 2010-12-25 12:32:23 +0200

* mail/escape.c (run_editor): Fix a typo.

Sergey Poznyakoff authored 2010-12-24 15:24:09 +0200

* libmailutils/base/list.c (list_itrctl): Accept mu_itrctl_set_direction
and mu_itrctl_qry_direction even if mu_iterator_first has not been called
yet.
* movemail/movemail.c: Rewrite using iterators.

* libmailutils/mailer/mailer.c (safe_address_create): Bugfix.

Sergey Poznyakoff authored 2010-12-23 23:46:38 +0200

* libmu_sieve/util.c (mu_sieve_error, mu_sieve_debug)
(mu_sieve_log_action): Format location only if locus.mu_file
is not NULL.

Sergey Poznyakoff authored 2010-12-23 16:33:25 +0200

* libmailutils/mailbox/mbxitr.c (mailbox_iterator)<backwards>: New member.
(mbx_first): Position to the last message if itr->backwards is set.
(mbx_next): Decrement index if itr->backwards is set.
(mbx_finished_p): Take into account iteration direction.
(mbx_itrctl): new method.
(mu_mailbox_get_iterator): Set itrctl method.

Sergey Poznyakoff authored 2010-12-23 16:16:29 +0200

New configuration options allow to specify the maximum number of messages
to be copied and control the actions of movemail when an error occurs while
appending a message.

* movemail/movemail.c (ONERROR_OPTION,MAX_MESSAGES_OPTION): New option codes.
(options): New options --onerror and --max-messages.
(max_messages_option, onerror_flags): New variable.
(ONERROR_SKIP, ONERROR_DELETE, ONERROR_COUNT): New defines.
(parse_opt): Handle ONERROR_OPTION.
(cb_onerror): New callback.
(movemail_cfg_param): New configuration statements: "max-messages"
and "onerror".
(move_message): Delete the message if ONERROR_DELETE is set.
(main): Handle the limit on the number of processed messages and
onerror flags.
Use mu_mailbox_expunge instead of mu_mailbox_flush.  This preserves
the attributes of not processed options (in case max_messages_option is
not 0) and speeds up the things considerably, especially on huge
mailboxes.

Sergey Poznyakoff authored 2010-12-23 16:07:07 +0200

Be more liberal when guessing sender and recipient names. Tolerate
deviations from RFC822.

* libmailutils/mailer/mailer.c (copy_fragment)
(recover_email, safe_address_create): New functions.
(_set_from, _set_to): Use safe_address_create.

Sergey Poznyakoff authored 2010-12-23 16:05:02 +0200

* frm/common.c [!HAVE_LIBFRIBIDI] (puts_bidi): Fix definition.
* libproto/pop/mbox.c (pop_destroy): Fix coredump (occurred
if the mailbox has not been scanned).

Sergey Poznyakoff authored 2010-12-23 16:02:39 +0200

* libmailutils/base/lcall.c (mu_parse_lc_all): Allow for arg==NULL.
* mh/Makefile.am: Define mhlibdir.
* mh/pick.y (match_header): Use sget accessors.
* mh/repl.c: Accept -noquery silently.

Sergey Poznyakoff authored 2010-12-23 13:34:17 +0200

* mail/mail.h (mail_execute): Change signature. All callers updated.
* mail/shell.c (expand_bang): Change signature.  Take the
string to be expanded as the 2nd and the last command as 3rd arguments.
Always allocate the return string, even if there's nothing to expand.
(mail_execute): fix memory management.
* mail/escape.c: Update.
* mail/escape.c: Update calls to mail_execute.

Sergey Poznyakoff authored 2010-12-23 12:42:40 +0200

* libmu_sieve/util.c: Update.

Sergey Poznyakoff authored 2010-12-23 12:25:26 +0200

* libmailutils/stream/logstream.c (_log_ctl): Handle MU_IOCTL_SYSLOGSTREAM,
pass it to the transport stream.
* libmu_sieve/sieve.l (pop_source): Restore input_stream.
* libmu_sieve/util.c (mu_sieve_error, mu_sieve_debug)
(mu_sieve_log_action): Set location information on the errstream.

Sergey Poznyakoff authored 2010-12-23 02:16:37 +0200

* sieve/tests/list.at: New file.
* sieve/tests/Makefile.am (TESTSUITE_AT): Add list.at.
* sieve/tests/testsuite.at: Include list.at.

Sergey Poznyakoff authored 2010-12-23 00:48:31 +0200

New parser accepts range specifications (mailbox.trace3-prot).
mu_debug_format_spec outputs specs in the canonical form.

* include/mailutils/debug.h (MU_DEBUG_LEVEL_RANGE): New macro.
(mu_debug_set_category_level): Change return type to int.
(mu_debug_get_category_level): New proto.
* libmailutils/diag/debug.c (mu_debug_set_category_level): Change
return type to int.
(mu_debug_get_category_level): New function.
(mu_debug_level_from_string): New function.
(parse_spec): Accept range specification.  Negation at the start
of spec implies 'proto'.
(mu_debug_format_spec): Rewrite.

* libmailutils/tests/debugspec.c: New file.
* libmailutils/tests/debugspec.at: New file.
* libmailutils/tests/Makefile.am (noinst_PROGRAMS): Add debugspec.
(TESTSUITE_AT): add debugspec.at
* libmailutils/tests/testsuite.at: Include debugspec.at.
* libmailutils/tests/.gitignore: Add debugspec.

* sieve/sieve.c: Do not advertise 'T' and 'P' arguments to --debug.
(debug_level): Remove.
(set_debug_level): Rewrite the handling of legacy debug specifiers 'TP'.

Sergey Poznyakoff authored 2010-12-22 22:48:39 +0200

* include/mailutils/types.hin (mu_debug_handle_t)
(mu_debug_level_t): New data types.
* include/mailutils/debug.h (mu_debug_level_p)
(mu_debug_category_level)
(mu_debug_set_category_level): Change argument types to
mu_debug_handle_t/mu_debug_level_t.
* libmailutils/diag/debug.c: Likewise.

* libmailutils/server/acl.c (_run_entry): Call mu_debug_log_nl
instead of mu_debug_log_end with an empty format string.

* include/mailutils/sieve.h
* libmailutils/filter/base64.c
* libmailutils/stream/stream.c
* libmu_sieve/conf.c
* libmu_sieve/extensions/spamd.c
* libmu_sieve/sieve.y
* sieve/sieve.c: Commit the changes c522de11 failed to commit.

Sergey Poznyakoff authored 2010-12-22 20:10:08 +0200

* libmailutils/filter/iconvflt.c (_icvt_decoder): Do not iconv_close
if cd is -1.
* mh/mboxprop.c (mh_mailbox_get_cur): Ignore whitespace following the cur
value.

Sergey Poznyakoff authored 2010-12-22 18:23:50 +0200

* libmu_sieve/extensions/pipe.c: Include sys/wait.h
* testsuite/Makefile.am: Distribute testsuite.inc

Sergey Poznyakoff authored 2010-12-22 14:38:59 +0200

* include/mailutils/filter.h (MU_FILTER_MAX_AGAIN): Add a comment.
* libmailutils/stream/fltstream.c (filter_read): Use
mu_debug on the filter.error level, instead of plain mu_error.
If the xcoder returns OK and does not consume all input when
processing the last buffer, assume mu_filter_again.
Fix loop condition.
(filter_write_internal): Use
mu_debug on the filter.error level, instead of plain mu_error.

Sergey Poznyakoff authored 2010-12-22 14:33:21 +0200

* include/mailutils/sieve.h (mu_sieve_debug_handle): New declaration.
(mu_sieve_debug_init): New prototype.
* libmu_sieve/conf.c (mu_sieve_debug_handle): New global.
(mu_sieve_module_init): Call mu_sieve_debug_init.
* libmu_sieve/extensions/spamd.c (spamd_connect_tcp)
(spamd_connect_socket): Fix stream creation.
(spamd_send_message): Switch to full buffering on the transport
stream and indicate it is a payload (in case transcript is enabled),
before copying data.  Restore things to their original state afterwards.
(spamd_read_line): Rewrite using mu_stream_getline.
(decode_float): Additional argument endp. Unless NULL, store there the
position in the input string where the parsing has stopped.
(parse_response_line): New function.
(spamd_test): Rewrite using new API.
* sieve/sieve.c (parser): --dry-run implies --verbose.

* libmailutils/filter/base64.c (_base64_decoder): when not enough data
are available and cmd is not mu_filter_lastbuf, return mu_filter_lastbuf.
* libmailutils/stream/stream.c (mu_stream_shutdown): Flush the buffers before
shutting the transport down.

* libmailutils/tests/fltst.c (main): New option bufsize=

Sergey Poznyakoff authored 2010-12-22 14:18:37 +0200

Sergey Poznyakoff authored 2010-12-22 14:17:24 +0200

* TODO: Update.
* include/mailutils/sieve.h (mu_sieve_library_path_prefix): New variable.
* libmu_argp/sieve.c (sieve_argp_option): New option --libdir-prefix.
(sieve_argp_parser): Handle --libdir-prefix.
* libmu_cfg/sieve.c (cb_library_path_prefix): New callback.
(mu_sieve_param): New statement "library-path-prefix".
* libmu_sieve/conf.c (mu_sieve_library_path_prefix): New variable.
(mu_sieve_module_init): Process prefix paths.
Do not call mu_sv_load_add_path.
* libmu_sieve/load.c (sieve_init_load_path): Rewrite.
(mu_sv_load_add_path): Remove.
* libmu_sieve/sieve-priv.h (mu_sv_load_add_path): Remove declaration.
(sieve_searchpath): Remove the unused "add" parameter.
* sieve/tests/moderator.at: Use MUT_SIEVE_OPTIONS in all tests.
* sieve/tests/testsuite.at (MUT_SIEVE_EXT_TEST): Use --libdir-prefix
option to ensure that our version of the extension appears first in
the path.

Sergey Poznyakoff authored 2010-12-22 14:17:20 +0200

* libmailutils/stream/fltstream.c (filter_ctl): MU_IOCTL_TRANSPORT
returns filter transport stream.
* libproto/pop/pop3_rdlist.c (mu_pop3_stream_to_list): Make sure
status is initialized and reflects the actual status.
* libproto/pop/pop3_stream.c (mu_pop3_filter_create): Do not unref
transport stream, it is done by the caller.

Sergey Poznyakoff authored 2010-12-22 11:42:05 +0200

* am/enable.m4 (MU_ENABLE_SUPPORT): Add the additional-cond argument.
(MU_ENABLE_BUILD): Likewise.
* configure.ac: Update 4th args in calls to MU_ENABLE_SUPPORT.
Do not use MU_ENABLE_BUILD within conditionals, use additional-cond
instead.
* libmailutils/stream/mapfile_stream.c: Include sys/stat.h

Sergey Poznyakoff authored 2010-12-21 02:48:28 +0200

* include/mailutils/debug.h (mu_debug_format_spec): New function.

* include/mailutils/stream.h (MU_IOCTL_SYSLOGSTREAM)
(MU_IOCTL_FILTER): New ioctls.
(MU_IOCTL_LOGSTREAM_GET_SEVERITY_MASK)
(MU_IOCTL_LOGSTREAM_SET_SEVERITY_MASK)
(MU_IOCTL_LOGSTREAM_CLONE)
(MU_IOCTL_SYSLOGSTREAM_SET_LOGGER)
(MU_IOCTL_SYSLOGSTREAM_GET_LOGGER)
(MU_IOCTL_FILTER_GET_DISABLED)
(MU_IOCTL_FILTER_SET_DISABLED): And their opcodes.
* include/mailutils/sys/filter.h (_MU_FILTER_DISABLED)
(_MU_FILTER_EOF): New defines.
(_mu_filter_stream) <eof>: Replace with fltflag (a bitmask).
* include/mailutils/sys/logstream.h (_mu_log_stream) <sevmask>: New
member.
* include/mailutils/sys/syslogstream.h (_mu_syslog_stream) <logger>: New
member.
* include/mailutils/util.h (mu_onexit_run): New proto.
* libmailutils/base/onexit.c (_mu_onexit_run): Extra safety check.
(mu_onexit_run): New function.
(mu_debug_level_str): New static.
(mu_debug_format_spec): New function.
* libmailutils/stream/fltstream.c (filter_read, filter_write): Bypass the
xcoder if _MU_FILTER_DISABLED is set.
Use fltflag instead of the removed eof.
(filter_ctl): Handle MU_IOCTL_FILTER.
* libmailutils/stream/logstream.c (_log_write): The sevmask member
masks out severity prefix output for certain severities.
(_log_ctl): Handle new opcodes (see above).
* libmailutils/stream/syslogstream.c (_syslog_stream_write): Use
<logger>, if supplied, instead of the system syslog(3).
(_syslog_ctl): Handle MU_IOCTL_SYSLOGSTREAM.
(mu_syslog_stream_create): Initialize logger to NULL.
* mu/ldflags.c (lib_descr): Protect entries with the
corresponding #ifdef ENABLE_whatever.

Sergey Poznyakoff authored 2010-12-20 22:34:02 +0200

Sergey Poznyakoff authored 2010-12-19 23:57:17 +0200

* include/mailutils/sys/amd.h (_amd_message_lookup_or_insert): New proto.
* libmailutils/base/amd.c (_amd_message_lookup_or_insert): New function.
(_amd_message_insert): Rewrite using _amd_message_lookup_or_insert.
* libproto/maildir/mbox.c (maildir_message_cmp): Stop comparison on
':'.
(maildir_message_lookup): Remove.
(maildir_scan_dir): Use _amd_message_lookup_or_insert.

* po/POTFILES.in: Update.

Sergey Poznyakoff authored 2010-12-19 22:26:28 +0200

* include/mailutils/debug.h (mu_debug_log_nl): New proto.
* libmailutils/diag/debug.c (mu_debug_log_nl): New function.
* libmailutils/mailer/progmailer.c: Use mu_debug_log_nl.
* libmailutils/server/acl.c: Likewise.
Also, use MU_DEBUG_TRACE9 instead of the numeric value.

* libmailutils/filter/iconvflt.c (_iconv_filter): Register encoder
(same as decoder).

Sergey Poznyakoff authored 2010-12-19 19:00:58 +0200

Wojciech Polak authored 2010-12-19 11:12:03 +0100

* libmu_sieve/extensions/pipe.c: Allow to specify which parts of the
message should be piped.
Implement "pipe" test.
* sieve/tests/pipeact.at: New file.
* sieve/tests/pipetest.at: New file.
* sieve/tests/Makefile.am (TESTSUITE_AT): Add pipeact.at
and pipetest.at
* sieve/tests/testsuite.at: Include pipeact.at
and pipetest.at
(MUT_SIEVE_EXT_TEST): Redefine MUT_SIEVE_OPTIONS.
Set envar "cwd".
Use cat and heredoc to create prog, instead of using AT_DATA.
* sieve/tests/moderator.at: Update to these changes.

Sergey Poznyakoff authored 2010-12-19 02:15:46 +0200

* libmu_sieve/util.c (mu_sieve_error): Fix typo.

Sergey Poznyakoff authored 2010-12-18 00:30:10 +0200

* libmu_sieve/extensions/moderator.c: Implement the :program tag.
Use _sget_ functions to reduce memory requirements.
* sieve/tests/moderator.mbox: New file.
* sieve/tests/moderator.at: New file.
* sieve/tests/Makefile.am (EXTRA_DIST): Add moderator.mbox.
(TESTSUITE_AT): Add moderator.at
* sieve/tests/testsuite.at (MUT_SIEVE_EXT_NAME): New define.
(MUT_SIEVE_EXT_TEST): New macro.
Include moderator.at.

Sergey Poznyakoff authored 2010-12-17 23:29:05 +0200