John McEleney / mailutils

* libproto/mbox/mbox.c (mbox_append_message): Fix qid calculation.

Sergey Poznyakoff authored 2010-02-17 23:19:21 +0200

* libproto/mailer/smtp.c (cram_md5): Remove left-over
assignment to challenge_len.

Sergey Poznyakoff authored 2010-02-11 08:36:14 +0200

* mailbox/base64.c (mu_base64_encode): Make sure output buffer
is null-terminated.
* imap4d/auth_gss.c (auth_gssapi): Assume buffer returned
by mu_base64_encode is null-terminated.
* libproto/mailer/smtp.c (cram_md5): Take challenge_len
as argument. All callers updated.
(smtp_auth): Fix eventual memory override. Assume buffer returned
by mu_base64_encode is nul-terminated.
(smtp_parse_ehlo_ack): Fix capability parsing: (a) do not depend
on the continuation marker ('-' or ' ') and (b) fix parsing of
the SIZE capablity.
Move call to mu_rtrim_cset out of the internal loop.

Sergey Poznyakoff authored 2010-02-10 00:32:00 +0200

* libmu_auth/tls.c (_tls_destroy): Destroy underlying streams,
unless MU_STREAM_NO_CLOSE is set.
(_tls_close): Likewise for close.

Sergey Poznyakoff authored 2010-02-09 16:30:01 +0200

* libproto/imap/mbox.c (imap_append_message0): Send trailing CRLF,
not just LF.
* mailbox/cfg_parser.y (mu_cfg_parse): Zero out _mu_cfg_debug
to avoid destroying it doubly.
* mailbox/mbx_default.c (plus_expand): Remove unused variable.

Sergey Poznyakoff authored 2010-02-09 16:29:48 +0200

* imap4d/id.c
* libproto/imap/folder.c
* libproto/pop/mbox.c
* sieve/sieve.c

Sergey Poznyakoff authored 2010-02-09 13:09:58 +0200

* sieve/testsuite/sieve/ext.exp [!HAVE_LIBLTDL]: Use unsupported
instead of returning 0.

Sergey Poznyakoff authored 2010-02-09 13:08:30 +0200

* libproto/mailer/remote.c: Fix compilation with --disable-sendmail.
* mail/testsuite/mail/send.exp: Ignore test (return UNSUPPORTED), if
sendmail support is not compiled.
* sieve/testsuite/sieve/redirect.exp: Likewise.
* sieve/testsuite/sieve/reject.exp: Likewise.

Sergey Poznyakoff authored 2010-02-09 12:52:02 +0200

* mailbox/mbx_default.c (plus_expand): Do not treat the part
between initial + and / as user name.
* mh/mh_format.c (print_fmt_segment): New function.
(print_fmt_string): Correctly handle multi-line inputs.

Sergey Poznyakoff authored 2010-01-27 23:09:15 +0200

* libmu_scm/mu_mailbox.c (mu-mailbox-get-port): Fix return value.
* libmu_scm/mu_port.c (mu_port_flush): Avoid warnings on passing
arg 2 to mu_stream_write.
(mu_port_free): Return 0.
* libmu_scm/mu_message.c (mu_scm_message_free): Return 0.

Sergey Poznyakoff authored 2010-01-14 16:04:31 +0200

* libmu_scm/mu_address.c: Use scm_to_locale_string
instead of relying on scm_i_string_chars.
* libmu_scm/mu_logger.c: Likewise.
* libmu_scm/mu_mailbox.c: Likewise.
* libmu_scm/mu_scm.c: Likewise.
* libmu_scm/mu_util.c: Likewise.
* libmu_scm/mu_message.c: Likewise.
(mu_scm_message_add_owner): Don't use SCM_NEWCELL.
(mu-message-get-envelope)
(mu-message-get-envelope-date): New functions.
(string_sloppy_member): Compare scm_i_string_length
bytes from the car.
(mu-message-get-header-fields): Don't use SCM_NEWCELL.
* libmu_scm/mu_port.c (mu_port_make_from_stream): Don't use SCM_NEWCELL.

Sergey Poznyakoff authored 2010-01-13 21:00:58 +0200

* mailbox/stream.c (mu_stream_readline): Account for terminating
null (fixes buffer overrun).
(mu_stream_getline): Fix reallocation condition.

Sergey Poznyakoff authored 2010-01-05 14:56:21 +0200

* configure.ac: Remove doc/rfc/Makefile.am
* doc/Makefile.am (SUBDIRS): Remove rfc.
(EXTRA_DIST): Add rfc/README.
* doc/rfc/README: New file.
* doc/rfc/CMC_V1.PS.gz: Remove.
* doc/rfc/Makefile.am: Remove.
* doc/rfc/rfc1413.txt: Remove.
* doc/rfc/rfc1521.txt: Remove.
* doc/rfc/rfc1731.txt: Remove.
* doc/rfc/rfc1734.txt: Remove.
* doc/rfc/rfc1738.txt: Remove.
* doc/rfc/rfc1870.txt: Remove.
* doc/rfc/rfc1891.txt: Remove.
* doc/rfc/rfc1892.txt: Remove.
* doc/rfc/rfc1893.txt: Remove.
* doc/rfc/rfc1894.txt: Remove.
* doc/rfc/rfc1939.txt: Remove.
* doc/rfc/rfc1957.txt: Remove.
* doc/rfc/rfc2045.txt: Remove.
* doc/rfc/rfc2046.txt: Remove.
* doc/rfc/rfc2047.txt: Remove.
* doc/rfc/rfc2049.txt: Remove.
* doc/rfc/rfc2060-errata
* doc/rfc/rfc2060.txt: Remove.
* doc/rfc/rfc2087.txt: Remove.
* doc/rfc/rfc2088.txt: Remove.
* doc/rfc/rfc2111.txt: Remove.
* doc/rfc/rfc2177.txt: Remove.
* doc/rfc/rfc2180.txt: Remove.
* doc/rfc/rfc2192.txt: Remove.
* doc/rfc/rfc2193.txt: Remove.
* doc/rfc/rfc2195.txt: Remove.
* doc/rfc/rfc2221.txt: Remove.
* doc/rfc/rfc2222.txt: Remove.
* doc/rfc/rfc2231.txt: Remove.
* doc/rfc/rfc2245.txt: Remove.
* doc/rfc/rfc2298.txt: Remove.
* doc/rfc/rfc2342.txt: Remove.
* doc/rfc/rfc2368.txt: Remove.
* doc/rfc/rfc2384.txt: Remove.
* doc/rfc/rfc2444.txt: Remove.
* doc/rfc/rfc2449.txt: Remove.
* doc/rfc/rfc2595.txt: Remove.
* doc/rfc/rfc2683.txt: Remove.
* doc/rfc/rfc2808.txt: Remove.
* doc/rfc/rfc2821.txt: Remove.
* doc/rfc/rfc2822.txt: Remove.
* doc/rfc/rfc2831.txt: Remove.
* doc/rfc/rfc3028.txt: Remove.
* doc/rfc/rfc3206.txt: Remove.
* doc/rfc/rfc3348.txt: Remove.
* doc/rfc/rfc3431.txt: Remove.
* doc/rfc/rfc3501.txt: Remove.
* doc/rfc/rfc3691.txt: Remove.
* doc/rfc/rfc4314.txt: Remove.
* doc/rfc/rfc821.txt: Remove.
* doc/rfc/rfc822.txt: Remove.
* doc/rfc/rfc934.txt: Remove.
* doc/rfc/sasl-mechanisms: Remove.

Sergey Poznyakoff authored 2010-01-05 14:29:15 +0200

* sieve/examples/ex-1.10.2.sv: Use GNU indentation style
* sieve/examples/ex-2.3a.sv: Likewise.
* sieve/examples/ex-2.5.1.sv: Likewise.
* sieve/examples/ex-2.7.3.sv: Likewise.
* sieve/examples/ex-3.1a.sv: Likewise.
* sieve/examples/ex-3.1b.sv: Likewise.
* sieve/examples/ex-3.2.sv: Likewise.
* sieve/examples/ex-4.1.sv: Likewise.
* sieve/examples/ex-4.2.sv: Likewise.
* sieve/examples/ex-4.4a.sv: Likewise.
* sieve/examples/ex-4.4b.sv: Likewise.
* sieve/examples/ex-4.5.sv: Likewise.
* sieve/examples/ex-5.1.sv: Likewise.
* sieve/examples/ex-5.7.sv: Likewise.
* sieve/examples/ex-9.sv: Likewise.
* sieve/examples/ex-save-all.sv: Likewise.
* sieve/examples/example.sv: Likewise.
* sieve/examples/exn-5.4.sv: Likewise.
* sieve/examples/t-complex.sv: Likewise.
* sieve/examples/t-exists.sv: Likewise.
* sieve/examples/t-fileinto.sv: Likewise.
* sieve/examples/t-mailutils.sv: Likewise.

Sergey Poznyakoff authored 2010-01-05 13:43:21 +0200

Happy GNU year!

Sergey Poznyakoff authored 2010-01-05 13:35:22 +0200

* libmu_cfg/init.c (mu_libcfg_parse_config): Do not produce error
if user configuration file is absent.
* libmu_sieve/sieve.l: Include config.h in %top section.
* mh/mh_alias.l: Likewise.
* mimeview/mimetypes.l: Likewise.
* mailbox/cfg_lexer.l: Likewise.
(mu_get_config): Call mu_cfg_tree_postprocess.

Sergey Poznyakoff authored 2010-01-02 13:23:51 +0200

* configure.ac, NEWS: Set version number 2.1.90

* testsuite/lib/mailutils.exp: Quote arguments to the --set option.
(mu_exec): escape backslashes and double-quotes in $sw.
* frm/testsuite/frm/test.exp: Quote arguments to the --set option.
* mail/testsuite/lib/mail.exp: Likewise.
* mailbox/testsuite/lib/mailbox.exp: Likewise.
* messages/testsuite/messages/test.exp: Likewise.
* sieve/testsuite/sieve/action.exp: Likewise.
* readmsg/testsuite/readmsg/test.exp: Remove extra backslashes,
not needed due to the changes in mu_exec

Sergey Poznyakoff authored 2009-12-29 21:23:25 +0200

* gnulib.modules (mbchar, mbiter, mbslen): New modules.
* mh/mh.h (mh_charset): New function.
* mh/mh_format.c (DFLWIDTH): New macro.
(mbsubstrlen, mbsnlen): New functions.
(compress_ws): Handle multibyte strings.
(put_string): Use number of characters, not
octets, to update ind.
(print_hdr_segment): Handle multibyte strings.
(print_simple_segment, print_fmt_string): Likewise.
(reset_fmt_defaults): Restore default WS compression.
(mh_format): Set LC_TYPE based on the settings of
profile variables Charset and LC_BASE (new variable).
* mh/mh_init.c (mh_charset): New function.
(mh_decode_2047): Use mh_charset.

Sergey Poznyakoff authored 2009-12-29 17:34:59 +0200

Remove obsolete options (these have been made hidden in
v. 2.0).  Handle "include" and "program" after parsing
the sources, not while reducing the tree, as was
previously.  Retain, however, old functions for compatibility,
making them deprecated.  Add "query" mode to mailutils-config.

* include/mailutils/cfg.h (mu_cfg_node_tag): Remove
(mu_cfg_statement): Rename to mu_cfg_node_statement.
(mu_cfg_tree): New member: tail.
(mu_cfg_perror): Change signature.
(mu_cfg_vperror, mu_cfg_parse_error): New protos.
(MU_CFG_PATH_DELIM, MU_CFG_PATH_DELIM_STR): New defines.
(MU_PARSE_CONFIG_PLAIN,MU_CFG_FMT_LOCUS): New constant.
(MU_CFG_DEPRECATED): New macro.
(mu_parse_config,mu_get_config): Deprecated.
(mu_cfg_format_parse_tree): Change signature.
(mu_cfg_format_node, mu_cfg_parse_file): New protos.
(mu_cfg_tree_free): Remove stale proto.
(mu_cfg_find_node, mu_cfg_create_subtree): New protos.
* include/mailutils/libcfg.h (mu_libcfg_parse_config): New proto.
(mu_parse_config_files): Deprecated.

* include/mailutils/mutil.h (mu_make_file_name): New proto.
(mu_retrieve_fp, mu_register_retriever)
(mu_retrieve): Remove unused prototypes.
* include/mailutils/opool.h (mu_opool_union): New proto.

* libmu_argp/Makefile.am (libmu_argp_a_SOURCES): Remove
sources (see below):
* po/POTFILES.in: Likewise.
* libmu_argp/gsasl.c: Remove.
* libmu_argp/pam.c: Remove.
* libmu_argp/radius.c: Remove.
* libmu_argp/sql.c: Remove.
* libmu_argp/tls.c: Remove.
* libmu_argp/virtdomain.c: Remove.

* config/mailutils-config.c: New option --query (-q)
(main): Handle query mode.

* comsat/comsat.c: Define MU_CFG_COMPATIBILITY to suppress
deprecation warnings.

* bootstrap.conf (XGETTEXT_OPTIONS): Add mu_cfg
error reporting functions.

* mailbox/Makefile.am (libmailutils_la_SOURCES): Add
mkfilename.c
* mailbox/mkfilename.c: New file.

* imap4d/imap4d.c: Remove obsolete option (hidden since 2.0)
* libmu_argp/auth.c: Likewise.
* libmu_argp/cmdline.c: Likewise.
* libmu_argp/tls.c: Likewise.
* pop3d/pop3d.c: Likewise.
* libmu_argp/common.c: Likewise.
(mu_common_argp_options): New option --set.

* libmu_argp/muinit.c (mu_app_init): Rewrite using parse
tree as a principal entity.
* libmu_cfg/init.c (mu_libcfg_parse_config): New function.
* mailbox/cfg_driver.c (make_file_name): Remove.
(_cb_include): Use mu_make_file_name.
(mu_build_container): Use deprecated code only unless MU_PARSE_CONFIG_PLAIN
flag is set.
(mu_cfg_tree_reduce): Do nothing if the tree is NULL.
* mailbox/cfg_format.c (format_node): Print locus optionally.
(mu_cfg_format_parse_tree): Take additional argument.
(mu_cfg_format_node): New function.
* mailbox/cfg_lexer.l: Update calls to diagnostic functions.
(mu_cfg_parse_file): New function.
(mu_get_config): Rewrite.
* mailbox/cfg_parser.y (parse_tree): Replace with
parse_head, parse_tail. All usages updated.
(mu_cfg_free_node): New function.
(mu_cfg_vperror): New function.
(mu_cfg_perror,mu_cfg_parse_error): New function.
(mu_cfg_tree_union): New function.
(mu_cfg_tree_postprocess): New function.
(mu_cfg_find_section): Use MU_CFG_PATH_DELIM instead
of hardcoded slash.
(mu_cfg_value_eq): New function.
(mu_cfg_find_node): New function. Redesign of an old idea.
(mu_cfg_create_subtree): New function.
* mailbox/opool.c (mu_opool_union): New function.

* frm/testsuite/frm/test.exp: use --set option instead of
the obsolete --mail-folder.
* messages/testsuite/messages/test.exp: Likewise.
* sieve/testsuite/sieve/action.exp: Likewise.
* mail/testsuite/lib/mail.exp: use --set option instead of
the obsolete --mail-spool.
* mailbox/testsuite/lib/mailbox.exp: Likewise.
* testsuite/lib/mailutils.exp: Likewise.
* mailbox/mutil.c (mu_register_retriever)
(mu_retrieve): Remove unused functions.

Minor fix:

* frm/common.c (frm_abort): Initialize URL
before usage.
(frm_scan): Don't call frm_abort on a mailbox
that was not opened successfully.

Sergey Poznyakoff authored 2009-12-28 00:59:50 +0200

Whitespace compression in its current form interacts badly
with wide-character encodings. To prevent it from spoiling
wide charater text, it is disabled by default. The user may
turn it back on by setting "Compress-WS: yes" in his .mh_profile.

* mh/mh.h (MH_FMT_COMPWS): New format flag.
* mh/mh_format.c (COMPRESS_WS): New macro.
(reset_fmt_defaults): Set MH_FMT_COMPWS flag
if Compress-WS global parameter is set to true.
(mh_format, builtin_concat): Call COMPRESS_WS.

Sergey Poznyakoff authored 2009-12-26 11:05:48 +0200

Affected files:

* comsat/comsat.c
* examples/header.c
* examples/mailcap.c
* examples/pop3client.c
* examples/url-parse.c
* imap4d/fetch.c
* imap4d/id.c
* imap4d/list.c
* imap4d/select.c
* imap4d/status.c
* imap4d/store.c
* imap4d/sync.c
* imap4d/util.c
* include/mailutils/sieve.h
* libmu_argp/common.c
* libmu_argp/muinit.c
* libmu_sieve/actions.c
* libmu_sieve/extensions/pipe.c
* libmu_sieve/extensions/vacation.c
* libmu_sieve/prog.c
* libmu_sieve/require.c
* libmu_sieve/runtime.c
* libmu_sieve/sieve-priv.h
* libmu_sieve/sieve.y
* libproto/imap/folder.c
* libproto/imap/mbox.c
* libproto/mailer/sendmail.c
* libproto/mbox/mbox.c
* libproto/pop/pop3_list.c
* libproto/pop/pop3_stat.c
* maidag/lmtp.c
* maidag/sieve.c
* mail/copy.c
* mail/decode.c
* mail/envelope.c
* mail/eq.c
* mail/escape.c
* mail/from.c
* mail/mail.h
* mail/mailline.c
* mail/mailvar.c
* mail/size.c
* mail/util.c
* mail/write.c
* mailbox/cfg_format.c
* mailbox/folder.c
* mailbox/parse822.c
* mailbox/system.c
* messages/messages.c
* mh/folder.c
* mh/forw.c
* mh/inc.c
* mh/mh.h
* mh/mh_alias.l
* mh/mh_fmtgram.y
* mh/mh_getopt.h
* mh/mh_init.c
* mh/mh_msgset.c
* mh/mh_whatnow.c
* mh/mhn.c
* mh/pick.y
* mimeview/mimetypes.y
* python/libmu_py/debug.c
* sieve/sieve.c

Sergey Poznyakoff authored 2009-12-16 13:06:22 +0200

* mailbox/mbx_default.c (attach_auth_ticket): Do not
proceed if auth is NULL.
* mh/mh_getopt.h (struct mh_argp_data): Change return type
and signature of handler.
(mh_argp_parse): Likewise.
* mh/mh_argp.c (parse_opt): Rewrite using new
handler prototype.
(mh_argp_parse): Use new hanlder type.
Assign argp children.

* mh/mh_init.c (mh_init): Call mu_init_tls_libs.

* mh/ali.c: Update opt_handler
* mh/anno.c: Update opt_handler
* mh/burst.c: Update opt_handler
* mh/comp.c: Update opt_handler
* mh/fmtcheck.c: Update opt_handler
* mh/folder.c: Update opt_handler
* mh/forw.c: Update opt_handler
* mh/inc.c: Update opt_handler
* mh/install-mh.c: Update opt_handler
* mh/mark.c: Update opt_handler
* mh/mhl.c: Update opt_handler
* mh/mhn.c: Update opt_handler
* mh/mhparam.c: Update opt_handler
* mh/mhpath.c: Update opt_handler
* mh/pick.c: Update opt_handler
* mh/refile.c: Update opt_handler
* mh/repl.c: Update opt_handler
* mh/rmf.c: Update opt_handler
* mh/rmm.c: Update opt_handler
* mh/scan.c: Update opt_handler
* mh/send.c: Update opt_handler
* mh/sortm.c: Update opt_handler
* mh/whatnow.c: Update opt_handler
* mh/whom.c: Update opt_handler

Sergey Poznyakoff authored 2009-12-16 00:02:14 +0200

* libproto/mailer/smtp.c (smtp_open): Don't issue second
EHLO if STARTTLS failed.

Sergey Poznyakoff authored 2009-12-02 21:43:14 +0200

* libproto/mailer/smtp.c (_smtp_set_rcpt): Initialize smtp->ptr to
smtp->buffer, not NULL.
(smtp_close): Reset smtp->state.

Sergey Poznyakoff authored 2009-12-01 15:23:02 +0200

* mail/mail.c (parse_opt): Fix handling of the --user option.

Sergey Poznyakoff authored 2009-11-05 19:08:29 +0200

Jordi Mallach authored 2009-10-31 12:54:15 +0200

* libmu_scm/mu_guile.c: Include setjmp.h.
* readmsg/readmsg.c (readmsg_parse_opt): Bugfixes. Patch
by Steve Cotton.

Sergey Poznyakoff authored 2009-10-31 12:49:43 +0200

* include/mailutils/gsasl.h (mu_gsasl_module_data): Mark as extern.

Sergey Poznyakoff authored 2009-10-25 19:04:25 +0200

* examples/base64.c, examples/mta.c,
imap4d/auth_gss.c, imap4d/imap4d.c,
imap4d/preauth.c, libmu_auth/ldap.c,
libmu_auth/virtual.c, libmu_scm/mu_body.c,
libmu_scm/mu_port.c, libproto/mailer/smtp.c,
mailbox/acl.c, mailbox/secret.c, pop3d/pop3d.c,
python/libmu_py/address.c, sql/odbc.c: Fix argument
signedness.

* imap4d/fetch.c, imap4d/store.c (closures):
Change type of `count' to int, to match the
signature of util_msgset.
* include/mailutils/guile.h (mu_scm_message_get): Fix
return type (const is useless here).
* libmu_scm/mu_message.c (mu_scm_message_get): Likewise.
(scm_mu_message_copy): Fix type of the `wr' automatic variable.
* libmu_scm/mu_mime.c (mu_scm_mime_get): Remove const qualifier
from the return type.
* libmu_argp/cmdline.c: Include stdlib.h.

Sergey Poznyakoff authored 2009-10-25 18:52:41 +0200

* mailbox/assoc.c (assoc_remove): Fix incorrect copying
between assoc slots.
* mailbox/cfg_parser.y (STRTONUM): Remove useless
dereferencing. Change the loop from `while' to `for'.

Sergey Poznyakoff authored 2009-10-25 18:51:51 +0200

* config/mailutils-config.c: Terminate docstring with a period.
* dotlock/dotlock.c: Likewise.
* frm/frm.c: Likewise.
* frm/from.c: Likewise.
* imap4d/imap4d.c: Likewise.
* maidag/maidag.c: Likewise.
* pop3d/pop3d.c: Likewise.
* readmsg/readmsg.c: Likewise.
* sieve/sieve.c: Likewise.

Sergey Poznyakoff authored 2009-09-28 14:13:46 +0300

* comsat/comsat.c: Add docstring.
* movemail/movemail.c: Add docstring.

Jordi Mallach authored 2009-09-28 14:13:13 +0300

* include/mailutils/cfg.h (mu_cfg_perror): Mark as printflike.
(mu_cfg_format_error): Likewise.
* libmu_argp/radius.c (mu_radius_argp_option): Fix typo in the
docstring.
* mail/mail.h [!WITH_READLINE] (mailvar_set_compl): New define.

Sergey Poznyakoff authored 2009-09-24 21:09:42 +0300

* imap4d/auth_gsasl.c (auth_gsasl): Make IMAP server wait
for empty final client response.
* include/mailutils/gsasl.h (mu_gsasl_stream_create): Don't
use deprecated GNU SASL types.

Simon Josefsson authored 2009-09-24 20:58:40 +0300

* imap4d/imap4d.c (imap4d_cfg_param): New global
statement 'transcript'.
(imap4d_connection): The transcript parameter overrides
global imap4d_transcript settings.
* pop3d/pop3d.c (pop3d_cfg_param, pop3d_connection): Likewise.

Sergey Poznyakoff authored 2009-09-24 20:47:46 +0300

* imap4d/util.c (imap4d_getline): Do not report
ERR_NO_IFILE if an empty line is read.
* mailbox/msrv.c (server_section_parser): Catch
null tags.

Bugs reported by Simon Josefsson.

Sergey Poznyakoff authored 2009-09-24 20:38:19 +0300

* libproto/mbox/mboxscan.c (mbox_scan_internal): Fix
body size calculation: -1 was returned for empty body.
Bug reported by Con Tassios <ct@swin.edu.au>.
* po/POTFILES.in: Add mail/mailvar.c

Sergey Poznyakoff authored 2009-09-24 16:55:22 +0300

* NEWS: Update for version 2.1
* configure.ac: Update for version 2.1
(AM_INIT_AUTOMAKE): Add dist-lzma and dist-xz.
* bootstrap (slurp): Remove call to silentize:
not needed with recent gnulib.

Sergey Poznyakoff authored 2009-09-10 22:37:21 +0300

Wojciech Polak authored 2009-09-08 18:42:59 +0200

* python/libmu_py/auth.c (api_set_pam_service): New function.
* python/mailutils/auth.py (set_pam_service): New function.

Wojciech Polak authored 2009-09-02 17:05:22 +0200